Note: lists.zephyrproject.org will be down for maintenance on Monday, September 26th, starting at 9AM Pacific Time (4PM Monday September 26, 2022 UTC), for approximately one hour.
Re: Request review for re-alloc patch @k_mem_pool_alloc()
Andrew, Zhou Xin,toggle quoted messageShow quoted text
`ret` is checked against `-EAGAIN` in the `if` statement below. The calling function has to handle this error case; it's actually part of the documented interface. However, I agree that it should retry allocating until it reaches the timeout (or forever, if `timeout` is `K_FOREVER`), and it's not doing it in this case. In fact, the comment in pool_alloc() mentioning `-EAGAIN` seems to agree with your patch, but the current implementation doesn't.
So, yes, please send a pull request. GitHub is currently the best channel for this kind of discussion, as not only it's easier to track patches, the CI system will test them against a battery of tests to ensure things are not broken.
On 12/20/2017 09:34 AM, Boie, Andrew P wrote:
Can you please send this as a pull request in github?