On Thu, Feb 25, 2016 at 07:05:49AM -0800, Dirk Brandewie wrote:
On 02/24/2016 02:13 PM, Saucedo Tejada, Genaro wrote:
From 9baee79d211bfb94aeed970c55f31cd3c4b2a8ad Mon Sep 17 00:00:00 2001 From: Genaro Saucedo Tejada <genaro.saucedo.tejada(a)intel.com> Date: Fri, 19 Feb 2016 17:10:28 -0600 Subject: [PATCH] Log macros unified in a common API
Introduces a header to concentrate logging macro definitions for all code to reuse, change aims to provide all currently existing logging functionality so every C file can replace it's compile-unit definitions by common code.
Later enhancements to log can now be performed in a single file.
Features: * Optional printing of thread pointer * Optional printing of colored messages * Optional printing of a label to indicate logging level (info, error, warning, debug) * Caller function name printing * Incremental log levels * One point log disable
I like this in general we need a common set of debug output macros that all drivers can use. Currently we have a *bunch* of different versions of the same thing in use throughout the driver tree.
I don't like the naming, we already have a kernel event logging API people may assume that the two facilities are connected based on the name.
Can we change the names to debug_* or something else?
Again, do we want to take over _another_ namespace ? Maybe it should be sys_debug or sys_dbg or sys_dbg_log ?
The sample implementation is adding all these in logging.h, which is a public API file:
which are very generic names. Don't forget that the application writer is operating in the same C namespace, and we have been trying to keep the namespaces the kernel owns to a minimum to minimize the number or potential clashes:
It's the MACRO names the need fixed up IMO. Any functions that are added should be in the sys_* space sure. I didn't see any new C functions being added.
See doc/collaboration/code/naming_conventions.rst.
