Re: Sanity check and test cases


Maciek Borzecki <maciek.borzecki@...>
 

On Wed, Mar 30, 2016 at 4:47 PM, Maciek Borzecki
<maciek.borzecki(a)gmail.com> wrote:
Hi,

On Wed, Mar 30, 2016 at 4:21 PM, Yannis Damigos
<giannis.damigos(a)gmail.com> wrote:
Hi all,

a quick question regarding sanity check and test cases.
I modified the test-fifo test case reducing the amount of memory statically allocated for fibers' stack.
This permits the test_nano to compile on boards like nucleo-f103rb and arduino 101 sss.

I run the sanitycheck script:

./scripts/sanitycheck --inline-logs --all -T ./tests/kernel/test_fifo/

and all the tests passes:

Cleaning output directory /home/xekarfwtos/projects/zephyr/sanity-out
Selecting all possible platforms per test case
Building testcase defconfigs...
25 tests selected, 3 tests discarded due to filters
total complete: 25/ 25 failed: 0
25 of 25 tests passed with 0 warnings in 95 seconds


Is it safe to submit the patch to gerrit or should I first test it on real hardware (I do not own any of the platforms)?
You can post the patch and add me for review. From what I've seen,
there's ~10 tests that fail under sanitycheck with SRAM overflow from
hundreds of bytes, to couple of kBs. My idea was to go through the
failing ones and see if it's possible trim the amount of memory
required in the manner similar to what was done to the latency
benchmarks. If that's not possible, the test will get disabled for
this particular target.
Now that I've seen the patch it got me thinking. What if we added an
opt-in debug code for fiber/tasks that helped to measure stack usage?
This could be something really simple, like initializing the stack
area with some known pattern (ex. '.') and once the fiber/task is
finished, scan the stack to find the low point and print it out to the
console. Do you guys think this is reasonable?

Cheers,
--
Maciek Borzecki

Join devel@lists.zephyrproject.org to automatically receive all group messages.