Re: [RFCv2 1/2] misc: Add timer API


Benjamin Walsh <benjamin.walsh@...>
 

On Thu, Apr 21, 2016 at 06:51:19PM +0300, Luiz Augusto von Dentz wrote:
+extern struct sys_timer_queue *__global_tq;
^^
We try not to use double-underscores. Single one is enough, but since
this is a global symbol, it should have a more descriptive name.
I understood from the code that __ are used for internal/private
stuch, such as in uint64_t __noinit __start_tsc;, well without this
being stated in the coding style it is kind hard to to guess.
The only things that should be using double-underscore are the
attributes macros (e.g. __weak for __attribute__((__weak)))). There are
other cases, such as symbols from linker scripts, ARM and ARC exception
handlers, maybe others, but these are legacy from the old codebase, and
should be changed when we have the time.

Join devel@lists.zephyrproject.org to automatically receive all group messages.