Re: CMSIS, ksdk and nrf52 integration


Nashif, Anas
 

On 24/05/2016, 16:55, "Maureen Helm" <maureen.helm(a)nxp.com> wrote:



-----Original Message-----
From: Kumar Gala [mailto:kumar.gala(a)linaro.org]
Sent: Tuesday, May 24, 2016 1:43 PM
To: Nashif, Anas <anas.nashif(a)intel.com>
Cc: Maureen Helm <maureen.helm(a)nxp.com>; Cufi, Carles
<Carles.Cufi(a)nordicsemi.no>; devel(a)lists.zephyrproject.org
Subject: Re: [devel] CMSIS, ksdk and nrf52 integration


On May 24, 2016, at 12:44 PM, Nashif, Anas <anas.nashif(a)intel.com> wrote:



On 24/05/2016, 13:43, "Maureen Helm" <maureen.helm(a)nxp.com> wrote:



-----Original Message-----
From: Cufi, Carles [mailto:Carles.Cufi(a)nordicsemi.no]
Sent: Tuesday, May 24, 2016 9:47 AM
To: Nashif, Anas <anas.nashif(a)intel.com>; Maureen Helm
<maureen.helm(a)nxp.com>
Cc: devel(a)lists.zephyrproject.org
Subject: Re: CMSIS, ksdk and nrf52 integration

Hi Anas,


On 24/05/16 16:44, "Nashif, Anas" <anas.nashif(a)intel.com> wrote:

Hi Maureen, Carles:

In the interest of moving forward with CMSIS and related pending
changes, I am proposing the following:

- merge CMSIS+ksdk patches from Maureen
- add basic support in Kconfig and the Makefile to allow inclusion
of CMSIS headers by SoCs.
- change nrf52 port to use new location of cmsis headers. Carles,
will you be ok doing this?
Of course, in fact there should not be any work at all there as long
as the INCLUDE path points to the new location in a similar format:
<cmsis/file.h>. If we decide to drop the ³cmsis² namespace then it¹s
a simple change, I will make it of course.
I was planning to update my patches to add/modify the READMEs similar to
what Anas did for qmsi, change cmsis/Include to cmsis/include per the review
comments, and rebase ksdk to use the new checkpatch. I'll get this out later
today.

Why do we need this change if we intend to point the include path to be
cmsis/Include. I don’t think we should be changing this. It should get hidden
by something like:

subdir-ccflags-$(CONFIG_CMSIS) += -I$(srctree)/ext/hal/cmsis/Include/

Seems better to leave things alone as much as possible.
My preference is to leave it alone, but I thought I was outnumbered on that. Anas and Carles, your thoughts?
Don’t have any strong preference here, as long as it is hidden from the users ☺

Anas



I assume the cmsis addition will be two commits? One for the actual import,
and a second for any related Makefile/Kconfig/README bits?
I've got one commit, but just for the import and README. Makefile/Kconfig should be a separate commit


- k

Join devel@lists.zephyrproject.org to automatically receive all group messages.