Re: TCP/IPv4/uIP stack appears to be broken with recent commit


Paul Sokolovsky
 

Hello Jukka,

On Wed, 12 Oct 2016 15:39:44 +0300
Jukka Rissanen <jukka.rissanen(a)linux.intel.com> wrote:

Hi Paul,

we can revert https://gerrit.zephyrproject.org/r/#/c/4282/6 if needed.
The patch fixed an issue Rohit had though. Best would be to find a
solution that fixes both problems.
I'm aware of issues Rohit experienced, as I literally followed on his
footsteps to re-discover them. What weren't clear were root causes of
different issues and the best way to fix them, so there were
alternative and partial solutions proposed. In particular, he produced
https://gerrit.zephyrproject.org/r/#/c/4282, while I, later, - an
alternative solution https://gerrit.zephyrproject.org/r/#/c/4888/ ,
which happened to be merged first. I don't think I heard from Rohit
whether my patch fixed his issue (even though I tried to keep him in
loop both as a reviewer a via email updates), and I guess now it would
be really helpful to hear if
https://gerrit.zephyrproject.org/r/#/c/4282 makes any difference for
him, with #4888 merged couple of weeks before it.

#4282 clearly leads to regressions though (on its own, in interaction
with #4888, or some other patch which was merged since #4282 was
initially submitted).


Cheers,
Jukka


On Tue, 2016-10-11 at 20:22 +0300, Paul Sokolovsky wrote:
Hello,

To make sure that my comment to
https://gerrit.zephyrproject.org/r/#/c/4282/6 isn't lost, I'd like
to dup it with this email. The patch above has broke echo_server
TCP/IPv4 for me. When run on frdm_k64f over Ethernet, the
application answers pings, but being telneted to port 4242, it
doesn't echo TCP data. Note that the issue of "The trouble is that
that linkage between
the outgoing buffer and the connection hasn't been established at
the point data_is_sent_and_acked() is called" has been fixed some
time ago
by https://gerrit.zephyrproject.org/r/#/c/4888/ .

Reverting just that commit fixes issue for me.


--
Best Regards,
Paul

Linaro.org | Open source software for ARM SoCs
Follow Linaro: http://www.facebook.com/pages/Linaro
http://twitter.com/#!/linaroorg - http://www.linaro.org/linaro-blog

Join devel@lists.zephyrproject.org to automatically receive all group messages.