Re: [RFC] k_poll_signal name and MISRA
|
Nashif, Anas
I think this was just a typo __
toggle quoted messageShow quoted text
On 25/10/2018, 21:39, "devel@lists.zephyrproject.org on behalf of Abderrezak Mekkaoui" <devel@lists.zephyrproject.org on behalf of ab.mekka@gmail.com> wrote: Hi Flavio, First thing that came to my mind when I saw k_pll is a PLL. Hopefully there is a better abbreviation for poll than pll. Regards Abderrezak Mekkaoui
On 10/25/2018 4:06 PM, Flavio Ceolin wrote:
> Hi guys, > > MISRA-C rule 5.7 says that a tag name shall be a unique identifier, also > reuse tag names is an undefined behavior recognized in C99 (Section > 6.7.2.3). > > It happens that we have in Zephyr both a struct and a function called > k_poll_signal (there may be others cases in the project), the question > is, what it is preferable, change the function to something like, > k_pll_signal_signal() or change the struct nam ? In the latter, what is the > suggestion ? Remembering that I'll follow this pattern if necessary. > > > Regards, > Flavio Ceolin > > >
|
|
|