Re: [Zephyr-tsc] Github CODEOWNERS auto-assignment doesn't work as expected
|
alberto.piedras@...
Thanks Paul,
toggle quoted message
Show quoted text
Do you have some indication of when did this break? BR Alberto -----Original Message-----
From: tsc@... [mailto:tsc@...] On Behalf Of Paul Sokolovsky via Lists.Zephyrproject.Org Sent: Friday 26 April 2019 11:10 To: devel@...; tsc@... Cc: tsc@... Subject: [Zephyr-tsc] Github CODEOWNERS auto-assignment doesn't work as expected Hello, As was noticed in a few (multiple?) PRs, automatic reviewer assignment based on the CODEOWNERS file no longer works as expected, specifically fails to assign reviewers. A recent example of this is https://github.com/zephyrproject-rtos/zephyr/pull/15670 - while there's an entry: /subsys/net/ip/ @jukkar @tbursztyka @pfalcon in CODEOWNERS, I wasn't requested for review. Again, that's not the only case. For a clean-room test, I submitted https://github.com/zephyrproject-rtos/zephyr/pull/15683 and as can be seen, the reviewer list is empty. This is problematic, because there's a risk that under-reviewed changes will get into the codebase, causing regressions. So, raising to the awareness of the TSC. -- Best Regards, Paul Linaro.org | Open source software for ARM SoCs Follow Linaro: http://www.facebook.com/pages/Linaro http://twitter.com/#!/linaroorg - http://www.linaro.org/linaro-blog |
|
|