On Fri, 26 Apr 2019 09:25:17 +0000
"Alberto Escolar Piedras (ALPI)" <ALPI@oticon.com> wrote:
Do you have some indication of when did this break?
Well, I was on vacation for two weeks before Apr 15. It definitely
worked before that. And I saw first problematic case last week, after
returning from vacation. No idea if that might be related tohttps://github.com/zephyrproject-rtos/zephyr/commit/636a7af43e704e25af29b31d565399fc02fef408
- nothing wrong is seen here.
Actually, fishing for that link, I see that a whole bunch of changes
was made to the CODEOWNERS file just recently:https://github.com/zephyrproject-rtos/zephyr/commits/master/CODEOWNERS
Just imagine that any of those changes could break syntax a bit or
propagation of changes to it could glitch on Github side, leading to
the effect we see. And that's not counting a possible coincidence of
Github tighting up the syntax for that file...
[mailto:firstname.lastname@example.org] On Behalf Of Paul Sokolovsky via
Lists.Zephyrproject.Org Sent: Friday 26 April 2019 11:10 To:
email@example.com; firstname.lastname@example.org Cc:
email@example.com Subject: [Zephyr-tsc] Github CODEOWNERS
auto-assignment doesn't work as expected
As was noticed in a few (multiple?) PRs, automatic reviewer
assignment based on the CODEOWNERS file no longer works as expected,
specifically fails to assign reviewers.
A recent example of this is
https://github.com/zephyrproject-rtos/zephyr/pull/15670 - while
there's an entry:
/subsys/net/ip/ @jukkar @tbursztyka @pfalcon
in CODEOWNERS, I wasn't requested for review. Again, that's not the
For a clean-room test, I submitted
https://github.com/zephyrproject-rtos/zephyr/pull/15683 and as can be
seen, the reviewer list is empty.
This is problematic, because there's a risk that under-reviewed
changes will get into the codebase, causing regressions. So, raising
to the awareness of the TSC.
Linaro.org | Open source software for ARM SoCs Follow Linaro:
Linaro.org | Open source software for ARM SoCs
Follow Linaro: http://www.facebook.com/pages/Linarohttp://twitter.com/#
!/linaroorg - http://www.linaro.org/linaro-blog