- Post 2.3.0 PR merging
Re: Post 2.3.0 PR merging
toggle quoted messageShow quoted text
OK I see. Since you called out the 2-approver change as a cause of the bottleneck, I'm assuming there is data available on this.
I was looking around for discussion about the decision. The closest I found was here
. Is there something else?
A decision like that would need to go through the TSC, and in order to be able to vote we’d need to have clear stats on how many PRs are actually blocked by this policy. I was thinking
about this recently, and given that those in Zephyr with merge rights can in fact add their +1 and they typically rely on a maintainer’s review to decide whether to merge a PR or not, this might not have as big as an impact as I originally thought.
That said, I believe we need a new GitHub filter to help us. Right now, we have one that lists PRs that are approved, passing CI and ready to merge, but what we need is one that shows
all PRs that are partially approved (i.e. a single +1) and passing CI. Then those of us with merge rights could go over those regularly (like we do for the former) and, provided there’s a +1 from a maintainer, we could take one additional look at the PR, approve
it and merge it.
I’d very much like to hear the opinion of others with merge rights in this thread.
Join email@example.com to automatically receive all group messages.