Re: GitHub workflow issue: Dismissing your own review


Yannis Damigos
 

On Thu, Jul 13, 2017 at 2:12 PM, Paul Sokolovsky
<paul.sokolovsky@linaro.org> wrote:
Hello,

I spotted a following issue: if I gave negative ("change requested")
review (or just the same, positive review), I don't seem to be able to
change it back to "no review".

For example, if I looked at some patch and spotted a glaring typo, I'd
feel that warrants "requesting a change". But once submitter fixes it,
I can't reset my review to the neutral state. The only choice is to
approve the PR, but often, that's not a choice because I didn't review
PR in full, or not familiar enough with some subsystem.

https://github.com/blog/2265-dismissing-reviews-on-pull-requests
tells that review dismissal is possible, but doesn't document who can
dismiss a review. I definitely don't see "Dismiss review" links like
shown there, and can't dismiss my own review (which is of course a bug
in Github).

Can someone give suggestions what to do in this case? In particular,
can people with merge permissions check if they're shown "Dismiss
review" links like above?


Thanks,
Paul

Linaro.org | Open source software for ARM SoCs
Follow Linaro: http://www.facebook.com/pages/Linaro
http://twitter.com/#!/linaroorg - http://www.linaro.org/linaro-blog
_______________________________________________
Zephyr-devel mailing list
Zephyr-devel@lists.zephyrproject.org
https://lists.zephyrproject.org/mailman/listinfo/zephyr-devel
Hello,

https://help.github.com/articles/dismissing-a-pull-request-review
mentions "repository administrators or people with write access can
dismiss a review"

Yannis

Join devel@lists.zephyrproject.org to automatically receive all group messages.