Re: Changes to Review Process in Github


Gydesen, Emil
 

Hi Anas,

A question on the feature:

If I rebase a PR without changing the content, does it trigger request for new reviews?

Also a clarification:
The text says "New reviewable commits pushed" - Does that also trigger if you amend an existing commit and push that, or is it only if you add new commits?

Best regards,
Emil Gydesen
Software Developer, Nordic Semiconductor | +4528265669 | emil.gydesen@...


From: devel@... <devel@...> on behalf of Nashif, Anas via lists.zephyrproject.org <anas.nashif=intel.com@...>
Sent: Friday, February 11, 2022 15:41
To: devel@... <devel@...>
Subject: [Zephyr-devel] Changes to Review Process in Github
 

Hit send too fast… fixed subject.

 

From: Nashif, Anas <anas.nashif@...>
Date: Friday, February 11, 2022 at 9:40 AM
To: devel@... <devel@...>
Subject: Changes to

Hi,

The TSC has discussed and voted in favor of changing the pull request and review process by enabling options provided by Github.

 

Specifically, we will be enabling an option that will cause new reviewable commits pushed to a pull-request branch to dismiss existing pull request review approvals and asking reviewers to revisit and re-review the new changes since they last reviewed the PR.

 

For reference, here is the settings screen with the option enabled:

 

Graphical user interface, text, application, email

Description automatically generated

 

This means that you will be asked to re-review changes when new content is being added to a pull-request. Please continue to provide reviews and keep watching for changes and enhancements added to pull-requests as they evolve.

 

This change will go into effect immediately.

 

Regards,

Anas

Join devel@lists.zephyrproject.org to automatically receive all group messages.