Re: Changes to Review Process in Github

David Leach

Just FYI, for reasons unknown, GitHub is attributing the dismissed approved reviews to my account, dleach02. I am not doing this and I have submitted a bug to the GitHub support to get them to look into this.


David Leach


From: devel@... <devel@...> On Behalf Of Nashif, Anas via
Sent: Friday, February 11, 2022 8:42 AM
To: devel@...
Subject: [Zephyr-devel] Changes to Review Process in Github


Hit send too fast… fixed subject.


From: Nashif, Anas <anas.nashif@...>
Date: Friday, February 11, 2022 at 9:40 AM
To: devel@... <devel@...>
Subject: Changes to


The TSC has discussed and voted in favor of changing the pull request and review process by enabling options provided by Github.


Specifically, we will be enabling an option that will cause new reviewable commits pushed to a pull-request branch to dismiss existing pull request review approvals and asking reviewers to revisit and re-review the new changes since they last reviewed the PR.


For reference, here is the settings screen with the option enabled:


Graphical user interface, text, application, email

Description automatically generated


This means that you will be asked to re-review changes when new content is being added to a pull-request. Please continue to provide reviews and keep watching for changes and enhancements added to pull-requests as they evolve.


This change will go into effect immediately.




Join to automatically receive all group messages.