Date   

Re: Cleaning up drivers/ethernet Kconfig files

Piotr Mienkowski <piotr.mienkowski@...>
 

Hi Tomasz,

Thanks for the clarification. I was planning to add basic Atmel SAM E70 SoC support to the master branch and without SoC support the Ethernet driver will also not work. It's anyway still going to take some time so I think I'll wait with the Ethernet driver until the net branch is merged into the master.

Cheers,
Piotr


Re: Cleaning up drivers/ethernet Kconfig files

Tomasz Bursztyka
 

Hi Piotr,

I've created Ethernet driver for Atmel SAM board I'm working with, however integrating it cleanly with Zephyr is a bit tricky. I believe Kconfig files in drivers/ethernet directory need cleaning up.
Definitely.
Things are mixed up between net/ip/Kconfig and driver part.

You might want to take a look at net branch of Zephyr. (and port your
driver for it)
Such change will make sense there where we have NET_L2_ETHERNET in
net/yaip/l2/Kconfig
and ETHERNET in drivers/ethernet/Kconfig

(note: yaip name will disappear once the branch will be merged)

Tomasz


Issues:
- Currently Ethernet Drivers appear flat in the main Device Drivers Kconfig menu rather than in their own submenu like all other drivers.
- Ethernet Drivers are visible only if "> Networking > Generic networking support > Wired networking support (Ethernet drivers)" is selected. This means that it is not possible to use Ethernet driver without higher level networking stuff. While not common, I believe that we should support an application that wants to implement their own networking stack, e.g. to send pure ip packets in some very efficient way. Hiding lower level driver when some high level feature is not enabled also breaks the logic common to all other device drivers. It would be better if higher level feature selected lower level one as it is typically done.

Currently config ETHERNET which is defined in ./net/ip/Kconfig file is overloaded and means use Ethernet driver for wired networking as well as enable Ethernet drivers. I believe we need to split this config in two, e.g. NETWORKING_ETHERNET and ETHERNET.

Does that sound reasonable?

--
Piotr


Re: PCI enumeration and IRQ_CONNECT ?

Liu, Baohong
 

-----Original Message-----
From: Marcus Shawcroft [mailto:marcus.shawcroft(a)gmail.com]
Sent: Wednesday, October 12, 2016 2:59 AM
To: devel(a)lists.zephyrproject.org
Subject: [devel] PCI enumeration and IRQ_CONNECT ?

Hi,

A question has come up in one of the config_info refactor patches about the
relationship between PCI enumeration and IRQ_CONNECT.... (
https://gerrit.zephyrproject.org/r/#/c/5427/2 )

Can anyone shed some light on how PCI enumeration and IRQ_CONNECT
interact in the DW GPIO, I2C and SPI drivers?

Specifically, the initialization of these drivers appears to be that:
- PCI enumeration populates driver_data->pci_dev via a call to pci_bus_scan()
- irq_num is pulled out of the pci_dev structure and stored in the driver
context.
- irq_enable() is called to enable the irq_num
- IRQ_CONNECT() is called to connect a hardwired (static) IRQ number (e.g
CONFIG_INTEL_PORT_0_IRQ) to the interrupt service routine.

Hence we have an statically configured interrupt number passed to
IRQ_CONNECT() and an irq_num returned from PCI enumeration, and no
obvious connection between the two.

How does the isr get connected to the interrupt from pci enumeration?
IRQ_CONNECT is solely for compilation time. IRQ_CONNECT_DYNAMIC was for run time, but, it was removed weeks ago.


Cheers
/Marcus


Re: Porting to ARM Cortex-M7 / Atmel SAM E70 support

Piotr Mienkowski <piotr.mienkowski@...>
 

Hi Niheer,

Thanks a lot for the update and following up on the issue!

Regards,
Piotr


Cleaning up drivers/ethernet Kconfig files

Piotr Mienkowski <piotr.mienkowski@...>
 

I've created Ethernet driver for Atmel SAM board I'm working with, however integrating it cleanly with Zephyr is a bit tricky. I believe Kconfig files in drivers/ethernet directory need cleaning up.

Issues:
- Currently Ethernet Drivers appear flat in the main Device Drivers Kconfig menu rather than in their own submenu like all other drivers.
- Ethernet Drivers are visible only if "> Networking > Generic networking support > Wired networking support (Ethernet drivers)" is selected. This means that it is not possible to use Ethernet driver without higher level networking stuff. While not common, I believe that we should support an application that wants to implement their own networking stack, e.g. to send pure ip packets in some very efficient way. Hiding lower level driver when some high level feature is not enabled also breaks the logic common to all other device drivers. It would be better if higher level feature selected lower level one as it is typically done.

Currently config ETHERNET which is defined in ./net/ip/Kconfig file is overloaded and means use Ethernet driver for wired networking as well as enable Ethernet drivers. I believe we need to split this config in two, e.g. NETWORKING_ETHERNET and ETHERNET.

Does that sound reasonable?

--
Piotr


Re: Porting to ARM Cortex-M7 / Atmel SAM E70 support

Patel, Niheer <Niheer.Patel@...>
 

Hi Piotr,

-----Original Message-----
From: Piotr Mienkowski [mailto:piotr.mienkowski(a)schmid-telecom.ch]
Sent: Wednesday, October 12, 2016 1:48 AM
To: devel(a)lists.zephyrproject.org
Subject: [devel] Re: Porting to ARM Cortex-M7 / Atmel SAM E70 support

Hi,

Just a quick question, are there maybe any news regarding Atmel's license issue?
I.e. is Atmel going to provide its ASF library / register header files with Zephyr's
compatible license?
I spoke with a couple gentlemen from Atmel (now Microchip) last week. They are going to review the commits you have submitted to see whether they will allow the re-licensing. I just spoke with them last week, so I plan to follow up with them early next week to see if they have made any progress.

They seem appreciate the value of open source and what Zephyr is trying to achieve. I am optimistic, but this may take a little time. I appreciate your patience.

Regards,
Niheer

Thanks,
Piotr


Daily JIRA Digest

donotreply@...
 

NEW JIRA items within last 24 hours: 3
[ZEP-1061] Create a tool for finding out stack sizes automatically.
https://jira.zephyrproject.org/browse/ZEP-1061

[ZEP-1052] Native IP Stack documentation
https://jira.zephyrproject.org/browse/ZEP-1052

[ZEP-1060] Contributor guide for documentation missing
https://jira.zephyrproject.org/browse/ZEP-1060


UPDATED JIRA items within last 24 hours: 17
[ZEP-852] SPI API Update
https://jira.zephyrproject.org/browse/ZEP-852

[ZEP-19] IPSP node support
https://jira.zephyrproject.org/browse/ZEP-19

[ZEP-1002] Refactor save/restore feature from counter_qmsi_aonpt driver
https://jira.zephyrproject.org/browse/ZEP-1002

[ZEP-1001] Refactor save/restore feature from wdt_qmsi driver
https://jira.zephyrproject.org/browse/ZEP-1001

[ZEP-999] Refactor save/restore feature from gpio_qmsi driver
https://jira.zephyrproject.org/browse/ZEP-999

[ZEP-998] Refactor save/restore feature from uart_qmsi driver
https://jira.zephyrproject.org/browse/ZEP-998

[ZEP-996] Refactor save/restore feature from i2c_qmsi driver
https://jira.zephyrproject.org/browse/ZEP-996

[ZEP-997] Refactor save/restore feature from spi_qmsi driver
https://jira.zephyrproject.org/browse/ZEP-997

[ZEP-1000] Refactor save/restore feature from rtc_qmsi driver
https://jira.zephyrproject.org/browse/ZEP-1000

[ZEP-1003] Extend aio_comparator_qmsi driver to support save/restore peripheral context
https://jira.zephyrproject.org/browse/ZEP-1003

[ZEP-1004] Extend counter_qmsi_aon driver to support save/restore peripheral context
https://jira.zephyrproject.org/browse/ZEP-1004

[ZEP-1006] Extend soc_flash_qmsi driver to support save/restore peripheral context
https://jira.zephyrproject.org/browse/ZEP-1006

[ZEP-1005] Extend dma_qmsi driver to support save/restore peripheral context
https://jira.zephyrproject.org/browse/ZEP-1005

[ZEP-1008] Extend pwm_qmsi driver to support save/restore peripheral context
https://jira.zephyrproject.org/browse/ZEP-1008

[ZEP-1011] Extend usb_dc_dw driver to support save/restore peripheral context
https://jira.zephyrproject.org/browse/ZEP-1011

[ZEP-644] Zephyr SDK 0.8.2 newlib headers no longer provide gettimeofday() prototype by default
https://jira.zephyrproject.org/browse/ZEP-644

[ZEP-724] build on windows failed: 'make: execvp: uname: File or path name too long'
https://jira.zephyrproject.org/browse/ZEP-724


CLOSED JIRA items within last 24 hours: 0

RESOLVED JIRA items within last 24 hours: 0


Daily Gerrit Digest

donotreply@...
 

NEW within last 24 hours:
- https://gerrit.zephyrproject.org/r/5475 : DONT MERGE - break sanity AND checkpatch
- https://gerrit.zephyrproject.org/r/5467 : unified: Move memory map doxygen API documentation
- https://gerrit.zephyrproject.org/r/5464 : unified: Move mailbox doxygen API documentation
- https://gerrit.zephyrproject.org/r/5462 : unified: Make mailbox API parameter names consistent
- https://gerrit.zephyrproject.org/r/5461 : unified: Rework K_THREAD_DEFINE()
- https://gerrit.zephyrproject.org/r/5474 : net: Add convenience functions to write at arbitrary buffer offset.
- https://gerrit.zephyrproject.org/r/5457 : byteorder: Add buffer swap helpers
- https://gerrit.zephyrproject.org/r/5473 : unified: Remove unused K_MEM_POOL_SIZE() macro
- https://gerrit.zephyrproject.org/r/5472 : unified: Remove unused K_MEM_MAP_SIZE() macro
- https://gerrit.zephyrproject.org/r/5471 : unified: Fix k_msgq_init() parameter ordering
- https://gerrit.zephyrproject.org/r/5470 : unified, doc: Fix memory pool documentation
- https://gerrit.zephyrproject.org/r/5469 : unified: Make memory pool API parameter names consistent
- https://gerrit.zephyrproject.org/r/5468 : unified: Reorder K_MEM_MAP_INITIALIZER() parameters
- https://gerrit.zephyrproject.org/r/5466 : unified: Fix time units in memory map code
- https://gerrit.zephyrproject.org/r/5465 : unified: Reorder k_mem_map_init() parameters
- https://gerrit.zephyrproject.org/r/5463 : unified: Fix time units in mailbox code
- https://gerrit.zephyrproject.org/r/5458 : tests: Add a unit test for the byteorder buffer swap utilities
- https://gerrit.zephyrproject.org/r/5455 : Bluetooth: Kconfig: Option to set page timeout value
- https://gerrit.zephyrproject.org/r/5460 : Bluetooth: btp: Include Private Address generation interval
- https://gerrit.zephyrproject.org/r/5456 : Bluetooth: HCI: Set the Page timeout
- https://gerrit.zephyrproject.org/r/5459 : Bluetooth: tester: Add GAP Unpair command handler
- https://gerrit.zephyrproject.org/r/5445 : DONT MERGE - break sanity
- https://gerrit.zephyrproject.org/r/5454 : build: introduce a one-place switch to force using the unified kernel
- https://gerrit.zephyrproject.org/r/5453 : samples/ipm: fix markup
- https://gerrit.zephyrproject.org/r/5452 : tests/benchmark/latency_measure: use TC_END_REPORT() to report success
- https://gerrit.zephyrproject.org/r/5450 : samples/zoap_server: Add preliminar support for validation
- https://gerrit.zephyrproject.org/r/5449 : unified: Eliminate support for dynamic timers
- https://gerrit.zephyrproject.org/r/5446 : unified: Eliminate unimplemented unified kernel APIs
- https://gerrit.zephyrproject.org/r/5448 : unified: Eliminate k_stack_init_with_buffer()
- https://gerrit.zephyrproject.org/r/5447 : unified: Rationalize thread priority APIs
- https://gerrit.zephyrproject.org/r/5444 : iot/dns: Add '+' operator

UPDATED within last 24 hours:
- https://gerrit.zephyrproject.org/r/4623 : eth: Adjust ENC28J60 transmission/reception return codes.
- https://gerrit.zephyrproject.org/r/5186 : net: dhcpv4: Issue an NET_INFO when dhcpv4 allocates an IP.
- https://gerrit.zephyrproject.org/r/5185 : net: dhcpv4: Add received message debug.
- https://gerrit.zephyrproject.org/r/5184 : net: dhcpv4: Implement XID
- https://gerrit.zephyrproject.org/r/5006 : enc28j60: Adapt driver for native IP stack
- https://gerrit.zephyrproject.org/r/5429 : enc28j60: Fixes and issue with the rx result status.
- https://gerrit.zephyrproject.org/r/5164 : enc28j60: Modify echo client sample to support enc28j60
- https://gerrit.zephyrproject.org/r/5051 : enc28j60: Modify echo server sample to support enc28j60
- https://gerrit.zephyrproject.org/r/5378 : sensors: add TH02 temperature sensor (Grove)
- https://gerrit.zephyrproject.org/r/5379 : samples: TH02 temperature and humidity sensor sample
- https://gerrit.zephyrproject.org/r/4624 : eth: Add ENC28J60 support into Paho's MQTT publisher example
- https://gerrit.zephyrproject.org/r/4116 : Bluetooth: btp: Add Address Type to Read Controller Information rsp
- https://gerrit.zephyrproject.org/r/5442 : net: yaip: Add initial Bluetooth support
- https://gerrit.zephyrproject.org/r/5443 : net: echo_server: Add Bluetooth support
- https://gerrit.zephyrproject.org/r/5187 : net: dhcpv4: Adjust debug diagnostic wording.
- https://gerrit.zephyrproject.org/r/5427 : spi/intel: Move RW driver context from config to runtime structure.
- https://gerrit.zephyrproject.org/r/4555 : Bluetooth: HFP HF: SLC connection-Send/Parse BRSF
- https://gerrit.zephyrproject.org/r/4562 : Bluetooth: Sample: handsfree sample application
- https://gerrit.zephyrproject.org/r/5339 : unified: Add k_msgq_num_free_get() API
- https://gerrit.zephyrproject.org/r/5291 : unified: Rename msgQ macro parameter names
- https://gerrit.zephyrproject.org/r/5290 : unified: Add alignment parameter to K_MSGQ_DEFINE()
- https://gerrit.zephyrproject.org/r/5289 : unified: Remove unused K_MSGQ_SIZE() macro
- https://gerrit.zephyrproject.org/r/4541 : DONT MERGE - break checkpatch
- https://gerrit.zephyrproject.org/r/4457 : DONT MERGE - cause checkpatch warnings
- https://gerrit.zephyrproject.org/r/5137 : DONT MERGE - add changes to two different branches
- https://gerrit.zephyrproject.org/r/3114 : DONT MERGE - break doc
- https://gerrit.zephyrproject.org/r/5368 : gerrit: Fix code review vote
- https://gerrit.zephyrproject.org/r/5231 : arch/arm: add initial support for Cortex-M0/M0+
- https://gerrit.zephyrproject.org/r/4963 : samples: pwm: use new APIs and add more apps
- https://gerrit.zephyrproject.org/r/5105 : quark_se_c1000: add debug support to openocd config
- https://gerrit.zephyrproject.org/r/5439 : board: Enable ETH_DW for quark_x1000 if ETHERNET is enabled.
- https://gerrit.zephyrproject.org/r/5426 : quark_se: Make ipm console config structure static.
- https://gerrit.zephyrproject.org/r/5425 : ipm: Make config_info pointers const.
- https://gerrit.zephyrproject.org/r/4897 : x86 link: Specify ALIGN_WITH_INPUT for XIP data sections
- https://gerrit.zephyrproject.org/r/5438 : serial/ns16550: Move RW objects from driver config to driver context.
- https://gerrit.zephyrproject.org/r/5437 : gpio/dw: Move RW objects in config_info to driver_data
- https://gerrit.zephyrproject.org/r/5436 : i2c/dw: Move RW objects in config_info to driver_data
- https://gerrit.zephyrproject.org/r/5435 : spi/dw: Make config structure static.
- https://gerrit.zephyrproject.org/r/5381 : tests: test_ipm: Make device config structures static.
- https://gerrit.zephyrproject.org/r/5393 : pwm: qmsi: Remove RW data from driver config structure.
- https://gerrit.zephyrproject.org/r/5390 : serial/uart_qmsi: Make pointers to config_info const.
- https://gerrit.zephyrproject.org/r/5424 : i2c/qmsi_ss: Make pointers to config_info const.
- https://gerrit.zephyrproject.org/r/5389 : i2c/qmsi: Make pointers to config_info const.
- https://gerrit.zephyrproject.org/r/5387 : qmsi/dma: Make config_info pointers const.
- https://gerrit.zephyrproject.org/r/5388 : qmsi/dma: Remove unused channel[] from config_info
- https://gerrit.zephyrproject.org/r/5385 : gpio/sam3: Move RW data from driver config to runtime.
- https://gerrit.zephyrproject.org/r/5355 : LICENSING: clarify licenses of imported / reused code
- https://gerrit.zephyrproject.org/r/5384 : i2c/sam3: Make config_info pointers const.
- https://gerrit.zephyrproject.org/r/5382 : quark: ipm: Make driver config structures static.
- https://gerrit.zephyrproject.org/r/5353 : unified: Add alignment parameter to K_MEMORY_POOL_DEFINE()
- https://gerrit.zephyrproject.org/r/5362 : unified: Add alignment parameter to K_MEM_MAP_DEFINE()
- https://gerrit.zephyrproject.org/r/5118 : eth: Add KSDK ENET driver.
- https://gerrit.zephyrproject.org/r/5440 : tests: Add ethernet drivers to drivers/build_all

MERGED within last 24 hours:
- https://gerrit.zephyrproject.org/r/5077 : net: yaip: Fix net_nbuf_read corner cases
- https://gerrit.zephyrproject.org/r/5434 : net: yaip: Calculate UDP checksum in 6lowpan uncompression
- https://gerrit.zephyrproject.org/r/5273 : unified/doc: Update memory pools section of Kernel Primer
- https://gerrit.zephyrproject.org/r/5218 : arm: move atomic operations selection to the Cortex-M Kconfig
- https://gerrit.zephyrproject.org/r/5272 : unified/doc: Minor updates to thread sections in Kernel Primer
- https://gerrit.zephyrproject.org/r/5282 : unified/test: Fix issues affecting task test applications
- https://gerrit.zephyrproject.org/r/5281 : unified: Add legacy DEFINE_TASK support
- https://gerrit.zephyrproject.org/r/5278 : unified: Remove unimplemented kernel workload APIs
- https://gerrit.zephyrproject.org/r/5279 : unified: Enable legacy isr_task_id_get() & isr_task_priority_get()
- https://gerrit.zephyrproject.org/r/5287 : unified/test: Fix issues affecting LIFO object test application
- https://gerrit.zephyrproject.org/r/5283 : unified/test: Fix issues affecting test_critical application
- https://gerrit.zephyrproject.org/r/5280 : unified: Extend unified kernel sanity test coverage
- https://gerrit.zephyrproject.org/r/5354 : kernel: Fix to DEFINE_TASK() macro
- https://gerrit.zephyrproject.org/r/5284 : unified/test: Fix issues affecting stack canary applications
- https://gerrit.zephyrproject.org/r/5286 : unified/test: Fix issues affecting XIP test applications
- https://gerrit.zephyrproject.org/r/5285 : unified/test: Fix issues affecting static idt application
- https://gerrit.zephyrproject.org/r/4282 : net: fetch valid conn. to determine MSS in data_is_sent_and_acked()


Re: TCP/IPv4/uIP stack appears to be broken with recent commit

Paul Sokolovsky
 

Hello Jukka,

On Wed, 12 Oct 2016 15:39:44 +0300
Jukka Rissanen <jukka.rissanen(a)linux.intel.com> wrote:

Hi Paul,

we can revert https://gerrit.zephyrproject.org/r/#/c/4282/6 if needed.
The patch fixed an issue Rohit had though. Best would be to find a
solution that fixes both problems.
I'm aware of issues Rohit experienced, as I literally followed on his
footsteps to re-discover them. What weren't clear were root causes of
different issues and the best way to fix them, so there were
alternative and partial solutions proposed. In particular, he produced
https://gerrit.zephyrproject.org/r/#/c/4282, while I, later, - an
alternative solution https://gerrit.zephyrproject.org/r/#/c/4888/ ,
which happened to be merged first. I don't think I heard from Rohit
whether my patch fixed his issue (even though I tried to keep him in
loop both as a reviewer a via email updates), and I guess now it would
be really helpful to hear if
https://gerrit.zephyrproject.org/r/#/c/4282 makes any difference for
him, with #4888 merged couple of weeks before it.

#4282 clearly leads to regressions though (on its own, in interaction
with #4888, or some other patch which was merged since #4282 was
initially submitted).


Cheers,
Jukka


On Tue, 2016-10-11 at 20:22 +0300, Paul Sokolovsky wrote:
Hello,

To make sure that my comment to
https://gerrit.zephyrproject.org/r/#/c/4282/6 isn't lost, I'd like
to dup it with this email. The patch above has broke echo_server
TCP/IPv4 for me. When run on frdm_k64f over Ethernet, the
application answers pings, but being telneted to port 4242, it
doesn't echo TCP data. Note that the issue of "The trouble is that
that linkage between
the outgoing buffer and the connection hasn't been established at
the point data_is_sent_and_acked() is called" has been fixed some
time ago
by https://gerrit.zephyrproject.org/r/#/c/4888/ .

Reverting just that commit fixes issue for me.


--
Best Regards,
Paul

Linaro.org | Open source software for ARM SoCs
Follow Linaro: http://www.facebook.com/pages/Linaro
http://twitter.com/#!/linaroorg - http://www.linaro.org/linaro-blog


Re: TCP/IPv4/uIP stack appears to be broken with recent commit

Paul Sokolovsky
 

Hello Rohit,

On Wed, 12 Oct 2016 12:57:26 +0000
Rohit Grover <Rohit.Grover(a)arm.com> wrote:

Paul,

Can your issue be reproduced by the vanilla echo_server sample?
I'm not sure what you mean by "vanilla". Default configuration of
echo_server doesn't have IPv4 or TCP enabled, and one needs to enable
those to see the issue. There're no changes to echo_server beyond
that. Otherwise, the issue is reproducible with QEMU SLIP driver (setup
described in
https://wiki.zephyrproject.org/index.php?title=Networking-with-Qemu) (my
original test was with FDRM-K64F Ethernet driver). After "git revert
627feb92d4b01556891e232db6b9c9181899965b", QEMU SLIP starts to work,
just as FDRM-K64F Ethernet before.


rohit

> -----Original Message-----
> From: Jukka Rissanen [mailto:jukka.rissanen(a)linux.intel.com]
> Sent: 12 October 2016 13:40
> To: Paul Sokolovsky; devel(a)lists.zephyrproject.org; Rohit Grover
> Subject: Re: TCP/IPv4/uIP stack appears to be broken with recent
> commit
>
> Hi Paul,
>
> we can revert https://gerrit.zephyrproject.org/r/#/c/4282/6 if
> needed. The patch fixed an issue Rohit had thou. Best would be to
> find a solution that fixes both problems.
>
> Cheers,
> Jukka
>
>
> On Tue, 2016-10-11 at 20:22 +0300, Paul Sokolovsky wrote:
> > Hello,
> >
> > To make sure that my comment to
> > https://gerrit.zephyrproject.org/r/#/c/4282/6 isn't lost, I'd
> > like to dup it with this email. The patch above has broke
> > echo_server TCP/IPv4 for me. When run on frdm_k64f over
> > Ethernet, the application answers pings, but being telneted to
> > port 4242, it doesn't echo TCP data. Note that the issue of
> > "The trouble is that that linkage between the outgoing buffer
> > and the connection hasn't been established at the point
> > data_is_sent_and_acked() is called" has been fixed some time
> > ago by https://gerrit.zephyrproject.org/r/#/c/4888/ .
> >
> > Reverting just that commit fixes issue for me.
> >

IMPORTANT NOTICE: The contents of this email and any attachments are
confidential and may also be privileged. If you are not the intended
recipient, please notify the sender immediately and do not disclose
the contents to any other person, use it for any purpose, or store or
copy the information in any medium. Thank you.


--
Best Regards,
Paul

Linaro.org | Open source software for ARM SoCs
Follow Linaro: http://www.facebook.com/pages/Linaro
http://twitter.com/#!/linaroorg - http://www.linaro.org/linaro-blog


Re: TCP/IPv4/uIP stack appears to be broken with recent commit

Rohit Grover
 

Paul,

Can your issue be reproduced by the vanilla echo_server sample?

rohit

-----Original Message-----
> From: Jukka Rissanen [mailto:jukka.rissanen(a)linux.intel.com]
> Sent: 12 October 2016 13:40
> To: Paul Sokolovsky; devel(a)lists.zephyrproject.org; Rohit Grover
> Subject: Re: TCP/IPv4/uIP stack appears to be broken with recent commit
>
> Hi Paul,
>
> we can revert https://gerrit.zephyrproject.org/r/#/c/4282/6 if needed.
> The patch fixed an issue Rohit had thou. Best would be to find a solution
> that fixes both problems.
>
> Cheers,
> Jukka
>
>
> On Tue, 2016-10-11 at 20:22 +0300, Paul Sokolovsky wrote:
> > Hello,
> >
> > To make sure that my comment to
> > https://gerrit.zephyrproject.org/r/#/c/4282/6 isn't lost, I'd like to
> > dup it with this email. The patch above has broke echo_server
> > TCP/IPv4 for me. When run on frdm_k64f over Ethernet, the application
> > answers pings, but being telneted to port 4242, it doesn't echo TCP
> > data. Note that the issue of "The trouble is that that linkage between
> > the outgoing buffer and the connection hasn't been established at the
> > point data_is_sent_and_acked() is called" has been fixed some time ago
> > by https://gerrit.zephyrproject.org/r/#/c/4888/ .
> >
> > Reverting just that commit fixes issue for me.
> >

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


Re: TCP/IPv4/uIP stack appears to be broken with recent commit

Jukka Rissanen
 

Hi Paul,

we can revert https://gerrit.zephyrproject.org/r/#/c/4282/6 if needed.
The patch fixed an issue Rohit had thou. Best would be to find a
solution that fixes both problems.

Cheers,
Jukka

On Tue, 2016-10-11 at 20:22 +0300, Paul Sokolovsky wrote:
Hello,

To make sure that my comment to
https://gerrit.zephyrproject.org/r/#/c/4282/6 isn't lost, I'd like to
dup it with this email. The patch above has broke echo_server
TCP/IPv4 for me. When run on frdm_k64f over Ethernet, the application
answers pings, but being telneted to port 4242, it doesn't echo TCP
data. Note that the issue of "The trouble is that that linkage
between
the outgoing buffer and the connection hasn't been established at the
point data_is_sent_and_acked() is called" has been fixed some time
ago
by https://gerrit.zephyrproject.org/r/#/c/4888/ .

Reverting just that commit fixes issue for me.


PCI enumeration and IRQ_CONNECT ?

Marcus Shawcroft <marcus.shawcroft@...>
 

Hi,

A question has come up in one of the config_info refactor patches
about the relationship between PCI enumeration and IRQ_CONNECT.... (
https://gerrit.zephyrproject.org/r/#/c/5427/2 )

Can anyone shed some light on how PCI enumeration and IRQ_CONNECT
interact in the DW GPIO, I2C and SPI drivers?

Specifically, the initialization of these drivers appears to be that:
- PCI enumeration populates driver_data->pci_dev via a call to pci_bus_scan()
- irq_num is pulled out of the pci_dev structure and stored in the
driver context.
- irq_enable() is called to enable the irq_num
- IRQ_CONNECT() is called to connect a hardwired (static) IRQ number
(e.g CONFIG_INTEL_PORT_0_IRQ) to the interrupt service routine.

Hence we have an statically configured interrupt number passed to
IRQ_CONNECT() and an irq_num returned from PCI enumeration, and no
obvious connection between the two.

How does the isr get connected to the interrupt from pci enumeration?

Cheers
/Marcus


Re: Porting to ARM Cortex-M7 / Atmel SAM E70 support

Piotr Mienkowski <piotr.mienkowski@...>
 

Hi,

Just a quick question, are there maybe any news regarding Atmel's license issue? I.e. is Atmel going to provide its ASF library / register header files with Zephyr's compatible license?

Thanks,
Piotr


Re: Device driver configuration and driver_data distinction.

Francois Bedard <Francois.Bedard@...>
 

Hi,

The ARC EM Starter Kit board support is already in Zephyr as of release 1.4 (added by Chuck Jordan) but it doesn't use DW PWM at the moment.

Francois

-----Original Message-----
From: Tomasz Bursztyka [mailto:tomasz.bursztyka(a)linux.intel.com]
Sent: Tuesday, October 11, 2016 4:07 AM
To: devel(a)lists.zephyrproject.org
Subject: [devel] Re: Re: Re: Device driver configuration and driver_data distinction.

Hi Marcus,

All of the patches to achieve the above are all now on gerrit, most
have been merged already.

.. with the exception of the DW PWM driver, which so far as I can tell
does not compile for any board at this point in time,
https://jira.zephyrproject.org/browse/ZEP-1040. Is there a board that
this driver should work for?
Currently no.
However, if any pure ARC based boards come in, this might be found useful.

for instance
https://www.synopsys.com/dw/ipdir.php?ds=arc_em_starter_kit

Uses spi_dw, i2c_dw etc..

Tomasz


Re: TCP/IPv4/uIP stack appears to be broken with recent commit

Andy Ross
 

Paul Sokolovsky wrote (on Tuesday, October 11, 2016 10:22AM):
To make sure that my comment to
https://gerrit.zephyrproject.org/r/#/c/4282/6 isn't lost, I'd like to
dup it with this email. The patch above has broke echo_server
FWIW, I don't know enough about the uIP stack to add anything
technical, but:

An even better way to make sure that report isn't lost is to submit it
to the bug tracker. :)

https://jira.zephyrproject.org/

It should take the same LF authentication that gerrit does.

Andy


TCP/IPv4/uIP stack appears to be broken with recent commit

Paul Sokolovsky
 

Hello,

To make sure that my comment to
https://gerrit.zephyrproject.org/r/#/c/4282/6 isn't lost, I'd like to
dup it with this email. The patch above has broke echo_server
TCP/IPv4 for me. When run on frdm_k64f over Ethernet, the application
answers pings, but being telneted to port 4242, it doesn't echo TCP
data. Note that the issue of "The trouble is that that linkage between
the outgoing buffer and the connection hasn't been established at the
point data_is_sent_and_acked() is called" has been fixed some time ago
by https://gerrit.zephyrproject.org/r/#/c/4888/ .

Reverting just that commit fixes issue for me.

--
Best Regards,
Paul

Linaro.org | Open source software for ARM SoCs
Follow Linaro: http://www.facebook.com/pages/Linaro
http://twitter.com/#!/linaroorg - http://www.linaro.org/linaro-blog


Daily JIRA Digest

donotreply@...
 

NEW JIRA items within last 24 hours: 1
[ZEP-1051] mpool allocation failed after defrag twice...
https://jira.zephyrproject.org/browse/ZEP-1051


UPDATED JIRA items within last 24 hours: 6
[ZEP-784] Add support for Nordic Semiconductor nRF51822 SoC
https://jira.zephyrproject.org/browse/ZEP-784

[ZEP-779] Using current MinGW gcc version 5.3.0 breaks Zephyr build on Windows
https://jira.zephyrproject.org/browse/ZEP-779

[ZEP-724] build on windows failed: 'make: execvp: uname: File or path name too long'
https://jira.zephyrproject.org/browse/ZEP-724

[ZEP-735] Several Tests and Samples are broken for CONFIG_DEBUG
https://jira.zephyrproject.org/browse/ZEP-735

[ZEP-939] Different address used for advertising in non-connectable mode from oob data
https://jira.zephyrproject.org/browse/ZEP-939

[ZEP-982] Minimal libc has EWOULDBLOCK != EAGAIN
https://jira.zephyrproject.org/browse/ZEP-982


CLOSED JIRA items within last 24 hours: 1
[ZEP-907] (Fixed) Test memory pool support (with mailboxes)
https://jira.zephyrproject.org/browse/ZEP-907


RESOLVED JIRA items within last 24 hours: 5
[ZEP-793] (Fixed) DNS Resolver
https://jira.zephyrproject.org/browse/ZEP-793

[ZEP-605] (Fixed) SMP over BR/EDR
https://jira.zephyrproject.org/browse/ZEP-605

[ZEP-975] (Fixed) DNS client port to new IP stack
https://jira.zephyrproject.org/browse/ZEP-975

[ZEP-1014] (Fixed) [TCF] tests/bluetooth/init build fail
https://jira.zephyrproject.org/browse/ZEP-1014

[ZEP-1013] (Fixed) [TCF] samples/shell/microkernel build fail
https://jira.zephyrproject.org/browse/ZEP-1013


Daily Gerrit Digest

donotreply@...
 

NEW within last 24 hours:
- https://gerrit.zephyrproject.org/r/5443 : net: echo_server: Add Bluetooth support
- https://gerrit.zephyrproject.org/r/5442 : net: yaip: Add initial Bluetooth support
- https://gerrit.zephyrproject.org/r/5439 : board: Enable ETH_DW for quark_x1000 if ETHERNET is enabled.
- https://gerrit.zephyrproject.org/r/5438 : serial/ns16550: Move RW objects from driver config to driver context.
- https://gerrit.zephyrproject.org/r/5440 : tests: Add ethernet drivers to drivers/build_all
- https://gerrit.zephyrproject.org/r/5436 : i2c/dw: Move RW objects in config_info to driver_data
- https://gerrit.zephyrproject.org/r/5435 : spi/dw: Make config structure static.
- https://gerrit.zephyrproject.org/r/5426 : quark_se: Make ipm console config structure static.
- https://gerrit.zephyrproject.org/r/5424 : i2c/qmsi_ss: Make pointers to config_info const.
- https://gerrit.zephyrproject.org/r/5425 : ipm: Make config_info pointers const.
- https://gerrit.zephyrproject.org/r/5427 : spi/intel: Move RW driver context from config to runtime structure.
- https://gerrit.zephyrproject.org/r/5441 : eth/dw: Move RW objects from device config_info to device driver_data.
- https://gerrit.zephyrproject.org/r/5437 : gpio/dw: Move RW objects in config_info to driver_data
- https://gerrit.zephyrproject.org/r/5434 : net: yaip: Calculate UDP checksum in 6lowpan uncompression
- https://gerrit.zephyrproject.org/r/5433 : iot/dns: Add support for Arduino 101 and ENC28J60
- https://gerrit.zephyrproject.org/r/5428 : tests/bluetooth/init/testcase.ini: add missing kernel=micro
- https://gerrit.zephyrproject.org/r/5431 : samples: add tagging to avoid microkernel running on nano only targets
- https://gerrit.zephyrproject.org/r/5429 : enc28j60: Fixes and issue with the rx result status.
- https://gerrit.zephyrproject.org/r/5430 : net: yaip: Disable warning about unused label

UPDATED within last 24 hours:
- https://gerrit.zephyrproject.org/r/5287 : unified/test: Fix issues affecting LIFO object test application
- https://gerrit.zephyrproject.org/r/5286 : unified/test: Fix issues affecting XIP test applications
- https://gerrit.zephyrproject.org/r/5285 : unified/test: Fix issues affecting static idt application
- https://gerrit.zephyrproject.org/r/5284 : unified/test: Fix issues affecting stack canary applications
- https://gerrit.zephyrproject.org/r/5282 : unified/test: Fix issues affecting task test applications
- https://gerrit.zephyrproject.org/r/5281 : unified: Add legacy DEFINE_TASK support
- https://gerrit.zephyrproject.org/r/5354 : kernel: Fix to DEFINE_TASK() macro
- https://gerrit.zephyrproject.org/r/5279 : unified: Enable legacy isr_task_id_get() & isr_task_priority_get()
- https://gerrit.zephyrproject.org/r/5278 : unified: Remove unimplemented kernel workload APIs
- https://gerrit.zephyrproject.org/r/5283 : unified/test: Fix issues affecting test_critical application
- https://gerrit.zephyrproject.org/r/5280 : unified: Extend unified kernel sanity test coverage
- https://gerrit.zephyrproject.org/r/5272 : unified/doc: Minor updates to thread sections in Kernel Primer
- https://gerrit.zephyrproject.org/r/5273 : unified/doc: Update memory pools section of Kernel Primer
- https://gerrit.zephyrproject.org/r/5064 : doc: yaip: Add a Network Management API usage document
- https://gerrit.zephyrproject.org/r/5390 : serial/uart_qmsi: Make pointers to config_info const.
- https://gerrit.zephyrproject.org/r/5393 : pwm: qmsi: Remove RW data from driver config structure.
- https://gerrit.zephyrproject.org/r/5388 : qmsi/dma: Remove unused channel[] from config_info
- https://gerrit.zephyrproject.org/r/5389 : i2c/qmsi: Make pointers to config_info const.
- https://gerrit.zephyrproject.org/r/5385 : gpio/sam3: Move RW data from driver config to runtime.
- https://gerrit.zephyrproject.org/r/5384 : i2c/sam3: Make config_info pointers const.
- https://gerrit.zephyrproject.org/r/5382 : quark: ipm: Make driver config structures static.
- https://gerrit.zephyrproject.org/r/5387 : qmsi/dma: Make config_info pointers const.
- https://gerrit.zephyrproject.org/r/5381 : tests: test_ipm: Make device config structures static.
- https://gerrit.zephyrproject.org/r/5232 : driver: Fixed Atmel SAM3 serial driver.
- https://gerrit.zephyrproject.org/r/5231 : arch/arm: add initial support for Cortex-M0/M0+
- https://gerrit.zephyrproject.org/r/5077 : net: yaip: Fix net_nbuf_read corner cases
- https://gerrit.zephyrproject.org/r/5006 : enc28j60: Adapt driver for native IP stack
- https://gerrit.zephyrproject.org/r/5355 : LICENSING: clarify licenses of imported / reused code
- https://gerrit.zephyrproject.org/r/5377 : doc: power_mgmt: Update references to PMA and control functions
- https://gerrit.zephyrproject.org/r/5379 : samples: TH02 temperature and humidity sensor sample
- https://gerrit.zephyrproject.org/r/5378 : sensors: add TH02 temperature sensor (Grove)
- https://gerrit.zephyrproject.org/r/4963 : samples: pwm: use new APIs and add more apps
- https://gerrit.zephyrproject.org/r/5164 : enc28j60: Modify echo client sample to support enc28j60
- https://gerrit.zephyrproject.org/r/5051 : enc28j60: Modify echo server sample to support enc28j60
- https://gerrit.zephyrproject.org/r/5194 : stm32l4: add initial soc support for stm32l4
- https://gerrit.zephyrproject.org/r/4883 : sanity: enable sanity multiple configuration
- https://gerrit.zephyrproject.org/r/5184 : net: dhcpv4: Implement XID
- https://gerrit.zephyrproject.org/r/5191 : net: Respect ether_type field.
- https://gerrit.zephyrproject.org/r/5137 : TEST: add changes to two different branches
- https://gerrit.zephyrproject.org/r/4541 : DONT MERGE
- https://gerrit.zephyrproject.org/r/5419 : drivers/pwm: fix pwm_qmsi_set_values() return error
- https://gerrit.zephyrproject.org/r/3114 : test: break doc
- https://gerrit.zephyrproject.org/r/5119 : iot/zoap: Add helper for generating tokens
- https://gerrit.zephyrproject.org/r/4917 : iot/zoap: Port to the native stack
- https://gerrit.zephyrproject.org/r/4457 : DONT MERGE
- https://gerrit.zephyrproject.org/r/5097 : iot/zoap: Add support for error 4.15
- https://gerrit.zephyrproject.org/r/5096 : zoap: Fix alignment of multiline function arguments
- https://gerrit.zephyrproject.org/r/5120 : samples/zoap_client: Use token generator helper

MERGED within last 24 hours:
- https://gerrit.zephyrproject.org/r/5336 : Bluetooth: Add well known keys to storage API for legacy pairing
- https://gerrit.zephyrproject.org/r/5224 : unified: clean-up timeout code for unpending a thread
- https://gerrit.zephyrproject.org/r/5221 : unified: streamline "timeout abort" internal interface
- https://gerrit.zephyrproject.org/r/5102 : unified: un-comment k_thread_[suspend|resume|abort_handler_set]
- https://gerrit.zephyrproject.org/r/5101 : dlist: add sys_dlist_peek_head_not_empty()
- https://gerrit.zephyrproject.org/r/5366 : unified: use _is_thread_pending() rather than poking in _timeout
- https://gerrit.zephyrproject.org/r/5225 : unified: remaining timeout cleanup
- https://gerrit.zephyrproject.org/r/5220 : unified/legacy: disable clock-based work_q APIs when no system clock
- https://gerrit.zephyrproject.org/r/5227 : unified: cleanup kernel initialization
- https://gerrit.zephyrproject.org/r/5104 : unified: cache the next thread to run
- https://gerrit.zephyrproject.org/r/5364 : unified: merge NANO_TIMERS and NANO_TIMEOUTS with SYS_CLOCK_EXISTS
- https://gerrit.zephyrproject.org/r/5223 : unified: streamline "timeout add" internal interfaces.
- https://gerrit.zephyrproject.org/r/5219 : unified: have __ticks_to_ms() return 0 when no system clock
- https://gerrit.zephyrproject.org/r/5103 : unified: use sys_dlist_peek_head_not_empty()
- https://gerrit.zephyrproject.org/r/5222 : unified/mem_pool: use K_NO_WAIT, not TICKS_NONE
- https://gerrit.zephyrproject.org/r/5365 : unified: do not compile out _k_neg_eagain when !CONFIG_ERRNO
- https://gerrit.zephyrproject.org/r/5367 : unified: fix remaining issues for building without SYS_CLOCK_EXIST
- https://gerrit.zephyrproject.org/r/5226 : unified: remove last instances of struct tcs
- https://gerrit.zephyrproject.org/r/5396 : quark_se: x86 core does not support ADC
- https://gerrit.zephyrproject.org/r/5394 : quark: dma: enable qmsi driver if DMA is selected
- https://gerrit.zephyrproject.org/r/5395 : frdm_k64: spi: fixed wrong kconfig used in driver
- https://gerrit.zephyrproject.org/r/5363 : unified: remove unused references from nano_private.h
- https://gerrit.zephyrproject.org/r/5397 : test: build all possible drivers on all platforms


Re: Device driver configuration and driver_data distinction.

Tomasz Bursztyka
 

Hi Marcus,

All of the patches to achieve the above are all now on gerrit, most
have been merged already.

.. with the exception of the DW PWM driver, which so far as I can tell
does not compile for any board at this point in time,
https://jira.zephyrproject.org/browse/ZEP-1040. Is there a board that
this driver should work for?
Currently no.
However, if any pure ARC based boards come in, this might be found useful.

for instance
https://www.synopsys.com/dw/ipdir.php?ds=arc_em_starter_kit

Uses spi_dw, i2c_dw etc..

Tomasz

6101 - 6120 of 7817