Re: RFC - C99 issue regarding unnamed union/structs
Flavio Ceolin
Hi Peter,
I don't have a solution, but since the question came up I am interestedI've given my opnion there :) Flavio Ceolin
|
||||||||||||||||||
|
||||||||||||||||||
Re: RFC - C99 issue regarding unnamed union/structs
Peter A. Bigot
I don't have a solution, but since the question came up I am interested in any reaction to https://github.com/zephyrproject-rtos/zephyr/issues/9552#issuecomment-449718078 since that's relevant to the topic.
toggle quoted messageShow quoted text
Peter
On 1/14/19 1:47 PM, Flavio Ceolin wrote:
Hi guys,
|
||||||||||||||||||
|
||||||||||||||||||
RFC - C99 issue regarding unnamed union/structs
Flavio Ceolin
Hi guys,
One problem with have in Zephyr regarding C99 is that we are using a lot of unnamed struct/unions. One example is: """ struct z_kernel { /* For compatibility with pre-SMP code, union the first CPU * record with the legacy fields so code can continue to use * the "_kernel.XXX" expressions and assembly offsets. */ union { struct _cpu cpus[CONFIG_MP_NUM_CPUS]; #ifndef CONFIG_SMP struct { /* nested interrupt count */ u32_t nested; /* interrupt stack pointer base */ char *irq_stack; /* currently scheduled thread */ struct k_thread *current; }; #endif }; ... """ Named this structs/unions is OK, just a matter of text-replace around the project. The problem is that we have some symbols being generated by macros and I didn't find a clean way to fix it without extra changes. The macro in question is GEN_OFFSET_SYM(). Take as example the following code: """ GEN_OFFSET_SYM(_kernel_t, current); """ If I change it for something like: """ GEN_OFFSET_SYM(_kernel_t, cpu.state.current); """ It won't work because this macro concats parameters 1 and 2 to make a new symbol. One solution is using a variadic parameter hack: """ #define GEN_OFFSET_SYM_INTERNAL_0(S, M) \ GEN_ABSOLUTE_SYM(__##S##_##M##_##OFFSET, offsetof(S, M)) #define GEN_OFFSET_SYM_INTERNAL_1(S, M, ALIAS) \ GEN_ABSOLUTE_SYM(__##S##_##ALIAS##_##OFFSET, offsetof(S, M)) #define GET_OVERRIDE(_1, _2, _3, NAME, ...) NAME #define GEN_OFFSET_SYM(...) \ GET_OVERRIDE(__VA_ARGS__, GEN_OFFSET_SYM_INTERNAL_1, \ GEN_OFFSET_SYM_INTERNAL_0)(__VA_ARGS__) """ The problem with this solution is that C99 requires at least one argument in a variadic macro. In other words, it also violates C99. The other possible solution is change (or add a new) macro that receives three parameters (the third is an alias). Do you guys have other solution ? if now which one you prefer, add a new macro or change the current one (and consequently all invocations). Regards, Flavio Ceolin
|
||||||||||||||||||
|
||||||||||||||||||
Re: Get RSSI in DTM(Zephyr)
Chettimada, Vinayak Kariappa
Hi Chen,
[vich] Yes, this is possible, but the command will have to be proprietary as per your test requirements.
In our experiences of other algorithm(LTE/WCDMA…etc.), RSSI usually can be detected easily in test mode via a CW tone. So it’s why we want to double check this. [vich] RSSI can be easily measured in nRF5x series chips during Radio Rx mode. Implementation will have to be as per your requirement, as standard DTM mode does not define any interface for RSSI in DTM mode.
[vich] Other customers may be doing so, but I am not aware of unless the implementation is submitted upstream via a PR.
Regards, Vinayak
From: Isaac Chen (陳尚航)
<Isaac_Chen@...>
Sent: 14 January 2019 04:08 To: Chettimada, Vinayak Kariappa <vinayak.kariappa.chettimada@...>; Tommy Lin (林志聰) <Tommy.Lin@...>; zephyr-devel@... Cc: Hanyu.Hsu@...; Rung-Sheng Lee (李榮盛) <Rung.Sheng.Lee@...>; Brent Tsai (蔡旻其) <Brent.Tsai@...>; Ryan Hsu (徐振鋒) <Ryan.Hsu@...> Subject: RE: Get RSSI in DTM(Zephyr) Importance: High
Hi Vinayak,
Our customer requested us to test conductive BLE RSSI in factory for accuracy improvement. Could you please clarify the following questions?
[vich] Yes, this is possible, but the command will have to be proprietary as per your test requirements.
In our experiences of other algorithm(LTE/WCDMA…etc.), RSSI usually can be detected easily in test mode via a CW tone. So it’s why we want to double check this. [vich] RSSI can be easily measured in nRF5x series chips during Radio Rx mode. Implementation will have to be as per your requirement, as standard DTM mode does not define any interface for RSSI in DTM mode.
[vich] Other customers may be doing so, but I am not aware of unless the implementation is submitted upstream via a PR.
Best Regards
Isaac Chen Quanta Computer Inc. Business Unit 11 BL1 Tel : +886-3-327-2345 Ext : 17585
This transmission is intended only for the use of the addressed recipient and may contain information that is privileged, confidential and exempt from disclosure under applicable law. If you are not the intended recipient, any use of this communication is strictly prohibited. If you have received this communication in error, please kindly notify the sender and delete this message immediately.
From: Chettimada, Vinayak Kariappa [mailto:vinayak.kariappa.chettimada@...]
Hi Tommy,
I don’t remember if DTM mode has any RSSI command in the Specification.
Could you please elaborate on your requirements?
Regards, Vinayak
From:
devel@... <devel@...>
On Behalf Of Tommy Lin (???)
Hi , We have a product using nRF51824 with zephyr. We use hci_uart sample code and follow below link , and we can get other BT device’s RSSI. https://devzone.nordicsemi.com/b/blog/posts/nrf5x-support-within-the-zephyr-project-rtos
We have a question , If it is in DTM(Direct Test Mode) , how can we get RSSI? Could you give us some suggestions.
Best regards, Tommy
|
||||||||||||||||||
|
||||||||||||||||||
Re: Get RSSI in DTM(Zephyr)
lairdjm
Hi Isaac, Generally you would be measuring the RSSI on the test equipment from a signal generated by your Bluetooth radio, and would be using a calibrated accurate test system. The nRF51824 (from the product spec) has an RSSI accuracy of +/-6dB, that is wildly inaccurate and I cannot see any reason to want to measure/record it on every module. You can add a non-standard command to read and return the RSSI if needed to the DTM code. Thanks, Jamie
From: devel@... [mailto:devel@...]
On Behalf Of Isaac Chen (???)
Sent: 14 January 2019 03:08 To: Chettimada, Vinayak Kariappa <vinayak.kariappa.chettimada@...>; Tommy Lin (林志聰) <Tommy.Lin@...>; zephyr-devel@... Cc: Hanyu.Hsu@...; Rung-Sheng Lee (李榮盛) <Rung.Sheng.Lee@...>; Brent Tsai (蔡旻其) <Brent.Tsai@...>; Ryan Hsu (徐振鋒) <Ryan.Hsu@...> Subject: Re: [Zephyr-devel] Get RSSI in DTM(Zephyr) Importance: High
Hi Vinayak,
Our customer requested us to test conductive BLE RSSI in factory for accuracy improvement. Could you please clarify the following questions?
In our experiences of other algorithm(LTE/WCDMA…etc.), RSSI usually can be detected easily in test mode via a CW tone. So it’s why we want to double check this.
Best Regards
Isaac Chen Quanta Computer Inc. Business Unit 11 BL1 Tel : +886-3-327-2345 Ext : 17585
This transmission is intended only for the use of the addressed recipient and may contain information that is privileged, confidential and exempt from disclosure under applicable law. If you are not the intended recipient, any use of this communication is strictly prohibited. If you have received this communication in error, please kindly notify the sender and delete this message immediately.
From:
Chettimada, Vinayak Kariappa [mailto:vinayak.kariappa.chettimada@...]
Hi Tommy,
I don’t remember if DTM mode has any RSSI command in the Specification.
Could you please elaborate on your requirements?
Regards, Vinayak
From:
devel@... <devel@...>
On Behalf Of Tommy Lin (???)
Hi , We have a product using nRF51824 with zephyr. We use hci_uart sample code and follow below link , and we can get other BT device’s RSSI. https://devzone.nordicsemi.com/b/blog/posts/nrf5x-support-within-the-zephyr-project-rtos
We have a question , If it is in DTM(Direct Test Mode) , how can we get RSSI? Could you give us some suggestions.
Best regards, Tommy
|
||||||||||||||||||
|
||||||||||||||||||
Re: Get RSSI in DTM(Zephyr)
Isaac Chen (陳尚航) <Isaac_Chen@...>
Hi Vinayak,
Our customer requested us to test conductive BLE RSSI in factory for accuracy improvement. Could you please clarify the following questions? 1. As I know, BLE RSSI can’t be measured in standard DTM mode. Is it possible to add new feature in DTM to support BLE RSSI measurement? 2. If the answer to the above question is “no”, I still need your confirmation if other test modes exist that can measure RSSI except DTM mode. In our experiences of other algorithm(LTE/WCDMA…etc.), RSSI usually can be detected easily in test mode via a CW tone. So it’s why we want to double check this. 3. Do you have any customers who have experiences to measure conductive RSSI in factory or in lab? If so, can you share the methodology?
Best Regards
Isaac Chen Quanta Computer Inc. Business Unit 11 BL1 Tel : +886-3-327-2345 Ext : 17585
This transmission is intended only for the use of the addressed recipient and may contain information that is privileged, confidential and exempt from disclosure under applicable law. If you are not the intended recipient, any use of this communication is strictly prohibited. If you have received this communication in error, please kindly notify the sender and delete this message immediately.
From: Chettimada, Vinayak Kariappa [mailto:vinayak.kariappa.chettimada@...]
Sent: Wednesday, January 09, 2019 8:00 PM To: Tommy Lin (林志聰); zephyr-devel@... Cc: Hanyu.Hsu@...; Isaac Chen (陳尚航); Rung-Sheng Lee (李榮盛); Brent Tsai (蔡旻其); Ryan Hsu (徐振鋒) Subject: RE: Get RSSI in DTM
Hi Tommy,
I don’t remember if DTM mode has any RSSI command in the Specification.
Could you please elaborate on your requirements?
Regards, Vinayak
From:
devel@... <devel@...>
On Behalf Of Tommy Lin (???)
Hi , We have a product using nRF51824 with zephyr. We use hci_uart sample code and follow below link , and we can get other BT device’s RSSI. https://devzone.nordicsemi.com/b/blog/posts/nrf5x-support-within-the-zephyr-project-rtos
We have a question , If it is in DTM(Direct Test Mode) , how can we get RSSI? Could you give us some suggestions.
Best regards, Tommy
|
||||||||||||||||||
|
||||||||||||||||||
Re: Timer using FRDM-K64F
Nicholas Yameen <Nicholas.Yameen@...>
Hi,
Thank you for the replies.
I will look into the suggested API’s as well as the other suggestions.
From: Andy Ross [mailto:andrew.j.ross@...]
Sent: Thursday, January 10, 2019 2:04 PM To: Cufi, Carles <carles.cufi@...>; Nicholas Yameen <Nicholas.Yameen@...>; devel@... Subject: Re: [Zephyr-devel] Timer using FRDM-K64F
[External email: Use caution with links and attachments]
Changing the k_timer API to work in some other unit than milliseconds is doable, though a little messy from a compatibility standpoint.
From: Cufi, Carles
<carles.cufi@...>
|
||||||||||||||||||
|
||||||||||||||||||
Re: Timer using FRDM-K64F
Andy Ross
Changing the k_timer API to work
in some other unit than milliseconds is doable, though a little
messy from a compatibility standpoint.
The underlying unit of ticks is configurable, and except for the tiny handful of remaining non-tickless targets, can now be arbitrary small (it's just the "unit of timekeeping" and doesn't correspond to interrupt frequency). The limits are the precision of the underlying timer and the overflow potential of 32 bit timeout API. Setting it to microseconds (and expecting it to be accurate at that level) should be possible on fast boards like K64F. The suggestion to use a driver for external hardware (and not the system timer) is a good one though, especially if you have tight requirements. IIRC the K64 has a bunch of timer devices instanced in addition to the ARM SysTick that Zephyr is using. Andy
From: Cufi, Carles
<carles.cufi@...>
Sent: Thursday, January 10, 2019 9:25AM To: Nicholas Yameen, Devel Subject: Re: [Zephyr-devel] Timer using FRDM-K64F
|
||||||||||||||||||
|
||||||||||||||||||
Re: Timer using FRDM-K64F
Carles Cufi
Hi there,
This has been requested several times, but as far as I know has not been completely solved yet. There is an issue here: https://github.com/zephyrproject-rtos/zephyr/issues/6498, please read through it and comment on your specific requirements so we try to gather all of them there in order to provide an implementation. In the meantime you can use the HAL’s APIs directly (this is mcux for the Freedom board I believe), which is what other users have done with nRF-based platforms.
Regards,
Carles
From: devel@... <devel@...>
On Behalf Of Nicholas Yameen
Sent: 10 January 2019 17:42 To: devel@... Subject: [Zephyr-devel] Timer using FRDM-K64F
Hello,
My team and I are developing an application that will need the use of timers using the FRDM-K64F board. The application requires a timer to be set using microseconds as the unit. Looking through the Zephyr and FRDM board documentation, I found that it supports millisecond resolution. Is it possible for Zephyr and the FRDM board to have a microsecond resolution? If so, are there examples of microsecond resolution? Thank you.
|
||||||||||||||||||
|
||||||||||||||||||
Timer using FRDM-K64F
Nicholas Yameen <Nicholas.Yameen@...>
Hello,
My team and I are developing an application that will need the use of timers using the FRDM-K64F board. The application requires a timer to be set using microseconds as the unit. Looking through the Zephyr and FRDM board documentation, I found that it supports millisecond resolution. Is it possible for Zephyr and the FRDM board to have a microsecond resolution? If so, are there examples of microsecond resolution? Thank you.
|
||||||||||||||||||
|
||||||||||||||||||
Re: Dev Meeting on Thursdays
Kumar Gala
I’ve created the ‘dev-review’ label for us to mark PRs for review in the meeting.
toggle quoted messageShow quoted text
- k
On Jan 9, 2019, at 3:54 PM, Kumar Gala <kumar.gala@linaro.org> wrote:
|
||||||||||||||||||
|
||||||||||||||||||
Dev Meeting on Thursdays
Kumar Gala
All,
If you have a PR or Issue that needs discussion we will use this call to talk about it. The meeting will use the time slot that we had for the bug triage meeting (10a Central US Standard Time). Here’s the meeting details: Zephyr Working Group is inviting you to a scheduled Zoom meeting. Join Zoom Meeting https://zoom.us/j/993312203 One tap mobile +16699006833,,993312203# US (San Jose) +16465588656,,993312203# US (New York) Dial by your location +1 669 900 6833 US (San Jose) +1 646 558 8656 US (New York) +1 877 369 0926 US Toll-free +1 855 880 1246 US Toll-free Meeting ID: 993 312 203 Find your local number: https://zoom.us/u/ankEMRagf
|
||||||||||||||||||
|
||||||||||||||||||
Re: Get RSSI in DTM
Chettimada, Vinayak Kariappa
Hi Tommy,
I don’t remember if DTM mode has any RSSI command in the Specification.
Could you please elaborate on your requirements?
Regards, Vinayak
From: devel@... <devel@...>
On Behalf Of Tommy Lin (???)
Sent: 08 January 2019 13:25 To: zephyr-devel@... Cc: Hanyu.Hsu@...; Isaac Chen (陳尚航) <Isaac_Chen@...>; Rung-Sheng Lee (李榮盛) <Rung.Sheng.Lee@...>; Brent Tsai (蔡旻其) <Brent.Tsai@...>; Ryan Hsu (徐振鋒) <Ryan.Hsu@...> Subject: [Zephyr-devel] Get RSSI in DTM
Hi , We have a product using nRF51824 with zephyr. We use hci_uart sample code and follow below link , and we can get other BT device’s RSSI. https://devzone.nordicsemi.com/b/blog/posts/nrf5x-support-within-the-zephyr-project-rtos
We have a question , If it is in DTM(Direct Test Mode) , how can we get RSSI? Could you give us some suggestions.
Best regards, Tommy
|
||||||||||||||||||
|
||||||||||||||||||
Get RSSI in DTM
Tommy Lin (林志聰) <Tommy.Lin@...>
Hi , We have a product using nRF51824 with zephyr. We use hci_uart sample code and follow below link , and we can get other BT device’s RSSI. https://devzone.nordicsemi.com/b/blog/posts/nrf5x-support-within-the-zephyr-project-rtos
We have a question , If it is in DTM(Direct Test Mode) , how can we get RSSI? Could you give us some suggestions.
Best regards, Tommy
|
||||||||||||||||||
|
||||||||||||||||||
Re: How does Zephyr brings dts, kernel, driver & user app together?
Stefan Jaritz
Hej ho Thanks Erwan for the reply. I checked the "dts/bindings/sensor/" dir to get an idea. If I get it right I need to create the files "xxx,codec1.yaml" and "xxx,codec2.yaml"? I don't like to dirty the zephyr source tree because I think mixing own stuff and official stuff will create problems on the long run. So how I do create an own "dts/bindings" binding dir and include it into the zephyr build process? I was checking for a zephyr related yaml doc. I put on the search
of official documentation page, but got no
description(https://docs.zephyrproject.org/1.13.0/search.html?q=yaml&check_keywords=yes&area=default).
There is a YAML spec (https://yaml.org/spec/1.2/spec.html) but I
misses the structure and keywords zephyr is using. Any idea were
to search for it? - or maybe a simple explained example Kind regards! Stefan
On 07/01/2019 09:26, Erwan Gouriou
wrote:
|
||||||||||||||||||
|
||||||||||||||||||
Re: How does Zephyr brings dts, kernel, driver & user app together?
Erwan Gouriou
Hi Stefan, To generate #define's from dt, you need to provide the matching yaml binding to indicate how fields should be decided, this should be done under dts/bindings/... Generated #define's will be available in build directory, under zephyr/include/generated/generated_... You should be able to use them as you wish. To make your driver somewhat generic (ie not depending on the node address, you'll need to provide intermediate #define in dts_fixup.h file (under soc/ or board/). For more information, you can check in various drivers how DT_xxxx constants are used Cheers Erwan
Le ven. 4 janv. 2019 à 17:30, Stefan Jaritz <stefan@...> a écrit : Hej,
|
||||||||||||||||||
|
||||||||||||||||||
How does Zephyr brings dts, kernel, driver & user app together?
Stefan Jaritz
Hej,
I like to create an user app that uses 2 IC connected via I2C with my MCU. Doing this is a bit tricky because I am missing some documentation, that is describing how the whole process goes. My setup is simple: 1.) custom board based on the stm32f412RG 1.1) the IC are connected via I2C 1.2) dts changes: &i2c1 { status = "ok"; clock-frequency = <I2C_BITRATE_FAST>; codec1@48 { compatible = "xxx,codec1"; reg = <0x48>; label = "codec1"; }; codec2@46 { compatible = "xxx,codec2"; reg = <0x46>; label = "codec2"; readAddr = <0x8F>; writeAddr = <0x8E>; }; }; 2.) user app 2.1) custom driver (codec1.c and codec2.c) How can I get the value of the I2C slave address from the dts inside of my source code? How can I find and access the c-files after the dts compilation? How Zephyr connects the c code of the dts, kernel, drivers, user drivers and app? Any help is welcome! Stefan
|
||||||||||||||||||
|
||||||||||||||||||
Re: PCA10059 without additional debugger - non-volatile storage of settings
Martin <ma@...>
Hi,
toggle quoted messageShow quoted text
in case anyone else is interested: lemrey has reworked the patch at https://github.com/zephyrproject-rtos/zephyr/pull/11210 today to address some comments. With the update, non-volatile storage of settings is also possible on the dongles. Note that flashing with nRF connect does not work and nrfutil has to be used instead. Thanks to everyone involved and I hope to see this in the official Zephyr master soon :) Martin Am Do., 27. Dez. 2018 um 15:02 Uhr schrieb Martin Jürgens <ma@jgs-wg.de>:
|
||||||||||||||||||
|
||||||||||||||||||
Re: Minimum required CMake version is now 3.13.1
Nashif, Anas
Yeah, forgot that the docs get updated only once a day L
Documentation is now being updated and will be available in the new version shortly.
Anas
From: devel@... [mailto:devel@...]
On Behalf Of Andy Ross
Sent: Thursday, January 3, 2019 12:31 PM To: Nashif, Anas <anas.nashif@...>; devel@... Subject: Re: [Zephyr-devel] Minimum required CMake version is now 3.13.1
Uh... those instructions still tell you to get cmake 3.8.2 :) From: Nashif, Anas
<anas.nashif@...>
|
||||||||||||||||||
|
||||||||||||||||||
Re: Minimum required CMake version is now 3.13.1
Andy Ross
Uh... those instructions still tell you to get cmake 3.8.2 :)
toggle quoted messageShow quoted text
The latest is currently at https://cmake.org/files/LatestRelease/cmake-3.13.2-Linux-x86_64.sh it seems. Andy
From: Nashif, Anas
<anas.nashif@...>
Sent: Thursday, January 03, 2019 9:12AM To: Nashif, Anas, Devel Subject: Re: [Zephyr-devel] Minimum required CMake version is now 3.13.1
|
||||||||||||||||||
|