|
Re: CODEOWNERS check in CI
Björn Stenberg
Oh! I somehow missed that. Thanks, that's good enough for me. -- Björn
On Tue, Feb 26, 2019 at 2:16 AM Nashif, Anas <anas.nashif@...> wrote:
|
|
|
|
Re: Seeing and running what CI does (was: CODEOWNERS check in CI)
Marc Herbert
Hi,
A couple things I find confusing: - There's only the ("beautified") output but not the commands that produced them as is typical in CI, so no obvious indication of what to do to test the next git push and make sure it will actually fix the issues before pushing again. - The comments with the output are typically some distance away from the red/green "traffic lights" with unrelated stuff in between - The "Details" buttons on the other hand *are* in the traffic lights and seem really designed to point at the output, I think most people expect them to but they point at the documentation instead.
> you do not have to look at the actual CI log which might be verbose and misleading
Well (most of) the actual CI log is or should be what one gets anyway when running the sanitycheck / compliance.py / etc. scripts locally so if that output is confusing then users will just submit patches to make it better (as I just did) and keep everything consistent.
The less difference and distance between users and CI, the better.
> The actual output is always available in a comment posted by zephyrbot in the same PR. The comment is updated for every run
It's interesting that this comment preserves some review history unlike the aggressive way the "traffic lights" in particular and github in general rewrite and bury review history. So this is Good but unfortunately inconsistent with (Bad) github so a bit confusing again. For instance it's difficult to relate the history of this comment to the corresponding git pushes and commits.
> We are planning at some point to use the Checks API from GH which would make things more clear.
Do you know some other (unrelated) project(s) to look at that already use this API?
Marc
From:
"Nashif, Anas" <anas.nashif@...>
Status is actually available as a comment in the PR. We are planning at some point to use the Checks API from GH which would make things more clear. The scripts now provide the output so you do not have to look at the actual CI log which might be verbose and misleading. If any information is missing in the comments posted by CI, please let us know.
Anas
From:
<devel@...> on behalf of Marc Herbert <marc.herbert@...>
Hi Björn,
I asked this question on Slack some time back and Anas answered it's not possible (yet?) for various reasons, one of them related to github accounts and security.
Fortunately something even more useful is already possible: running the checks yourself. Just run this compliance_script.py script: https://github.com/zephyrproject-rtos/ci-tools/tree/master/scripts https://github.com/zephyrproject-rtos/ci-tools/pulls
I know run this script *before* uploading anything to github as it obviously saves round trips and time. You also need the "sanitycheck" script in the other, main repo. I think sanitycheck is mentioned in the online documentation and the check_compliance about to be.
On a related CI topic, here's why the code coverage report is very often bogus: https://github.com/codecov/codecov-bash/issues/83 thumbs up to "vote" for it
Cheers,
Marc
From:
<devel@...> on behalf of Stenberg <bjorn@...>
Can we please make the "Details" links for these checks show the actual output of the check command, rather than the current generic information about why the check exists?
--
|
|
|
|
Re: Seeing and running what CI does (was: CODEOWNERS check in CI)
Nashif, Anas
Status is actually available as a comment in the PR. We are planning at some point to use the Checks API from GH which would make things more clear. The scripts now provide the output so you do not have to look at the actual CI log which might be verbose and misleading. If any information is missing in the comments posted by CI, please let us know.
Anas
From:
<devel@...> on behalf of Marc Herbert <marc.herbert@...>
Hi Björn,
I asked this question on Slack some time back and Anas answered it's not possible (yet?) for various reasons, one of them related to github accounts and security.
Fortunately something even more useful is already possible: running the checks yourself. Just run this compliance_script.py script: https://github.com/zephyrproject-rtos/ci-tools/tree/master/scripts https://github.com/zephyrproject-rtos/ci-tools/pulls
I know run this script *before* uploading anything to github as it obviously saves round trips and time. You also need the "sanitycheck" script in the other, main repo. I think sanitycheck is mentioned in the online documentation and the check_compliance about to be.
On a related CI topic, here's why the code coverage report is very often bogus: https://github.com/codecov/codecov-bash/issues/83 thumbs up to "vote" for it
Cheers,
Marc
From:
<devel@...> on behalf of Stenberg <bjorn@...>
Can we please make the "Details" links for these checks show the actual output of the check command, rather than the current generic information about why the check exists?
--
|
|
|
|
Re: CODEOWNERS check in CI
Nashif, Anas
The actual output is always available in a comment posted by zephyrbot in the same PR. The comment is updated for every run. Is this what you are looking for?
Anas
From:
<devel@...> on behalf of Björn Stenberg <bjorn@...>
Can we please make the "Details" links for these checks show the actual output of the check command, rather than the current generic information about why the check exists?
-- Björn
On Sun, Feb 24, 2019 at 1:57 PM Nashif, Anas <anas.nashif@...> wrote:
|
|
|
|
Seeing and running what CI does (was: CODEOWNERS check in CI)
Marc Herbert
Hi Björn,
I asked this question on Slack some time back and Anas answered it's not possible (yet?) for various reasons, one of them related to github accounts and security.
Fortunately something even more useful is already possible: running the checks yourself. Just run this compliance_script.py script: https://github.com/zephyrproject-rtos/ci-tools/tree/master/scripts https://github.com/zephyrproject-rtos/ci-tools/pulls
I know run this script *before* uploading anything to github as it obviously saves round trips and time. You also need the "sanitycheck" script in the other, main repo. I think sanitycheck is mentioned in the online documentation and the check_compliance about to be.
On a related CI topic, here's why the code coverage report is very often bogus: https://github.com/codecov/codecov-bash/issues/83 thumbs up to "vote" for it
Cheers,
Marc
From:
<devel@...> on behalf of Stenberg <bjorn@...>
Can we please make the "Details" links for these checks show the actual output of the check command, rather than the current generic information about why the check exists?
--
|
|
|
|
Re: Arduino interface definition for Nordic development kits
Erwan Gouriou
Hi Aaron,
This is indeed the expected way to do it. Don't forget to also add "arduino_i2c" in boards' yaml files. Cheers Erwan
|
|
|
|
Re: CODEOWNERS check in CI
Björn Stenberg
Can we please make the "Details" links for these checks show the actual output of the check command, rather than the current generic information about why the check exists? -- Björn
On Sun, Feb 24, 2019 at 1:57 PM Nashif, Anas <anas.nashif@...> wrote:
|
|
|
|
CODEOWNERS check in CI
Nashif, Anas
Hi, Recently we enabled a new CI check that verifies if newly added files are covered in the CODEOWNERS file.
For more information about the CODEOWNERS file please check https://help.github.com/en/articles/about-code-owners.
Whenever you are adding new files (new board, new driver, etc.) please add an entry in the CODEOWNERS file. This will mean that in the future you will be added as a reviewer when changes are submitted against those files and it is a way for others to know who is the maintainer of certain components without having to use `git blame` or other means.
If you think you are not the right owner of some files and you are just extending a component, please let us know (in the PR itself, on slack or per email) and we will advise what to add.
In the case where multiple names are associated with one or more files, the first name (github handle) is the maintainer/owner and additional names are co-maintainers/co-owners.
We are in the process of adding this to the documentation, so stay tuned for more information.
Regards, Anas
|
|
|
|
Arduino interface definition for Nordic development kits
Aaron Xu
Hi, When I try to compile "samples\shields\x_nucleo_iks01a1\" for my Nordic dev. kits(pca10040 and pca10056), occurred this error: Error: nrf52840_pca10056.dts.pre.tmp:437.1-13 Label or path arduino_i2c not found I noticed that the Arduino interface, like default i2c and so on, not been included in the Nordic dev. kits, either pca10040 or pca10056. So I add this patch to nrf52_pca10040.dts under "zephyr\boards\arm\nrf52_pca10040": @@ -97,7 +97,7 @@ And it works. My question is that, do I need to add Arduino interface definition to each of the Nordic development kit's DTS files?
|
|
|
|
Re: Shippable report coverage test failure
Thea Aldrich
Hi Aaron, Thanks so much for reaching out regarding PR #13658. A comment has been added directly to the PR. Please feel free to reach out if you have any questions. Thank you for your contribution to the Zephyr Project! Best, Thea Aldrich
On Fri, Feb 22, 2019 at 2:59 AM Aaron Xu <overheat1984@...> wrote:
|
|
|
|
Shippable report coverage test failure
Aaron Xu
Hello, Please help me check this PR: I am not quite understanding those coverage item meaning, but I believe this patch will solve issue #13658, at least on my boards those I have. Please give me some advice. Thanks,
|
|
|
|
Zephyr SDK 0.10.0-rc3 available
Nashif, Anas
Hi, Latest version of the SDK can be found here:
https://github.com/zephyrproject-rtos/sdk-ng/releases/tag/v0.10.0-rc3
Please download and try things out and report any issues.
Changes since the last release:
· Fixed multilib toolchains for x86 and nios2 · Updated to newlib 3.1.0 · qemu: Enable x86_64 target · Fixed newlib build for xtensa
Thanks to Kumar Gala for the great work fixing many of the issues and keeping things up to date.
Anas
|
|
|
|
Re: Long-Term Bluetooth Mesh Reliability
Martin <ma@...>
Hi Johan,
toggle quoted messageShow quoted text
thanks - that's good to know for sure. No luck unfortunately, my device is still not responding after some time. I have set CONFIG_DEBUG=y and from my understanding the application seems to run into an usage fault, which is not printed on UART unfortunately. If you are interested, I have attached myself to bug #12726 which seems to be about the same thing. Best, Martin Am So., 17. Feb. 2019 um 15:59 Uhr schrieb Hedberg, Johan <johan.hedberg@intel.com>:
|
|
|
|
BUGS (Zephyr v1.14.0-rc1) Feb 21 2019
Kumar Gala
255:bug
137:priority: medium 110:priority: low 8:priority: high 25:Coverity 20:area: Networking 17:area: Bluetooth 15:area: MISRA-C 14:platform: nRF 13:area: Logging 12:area: Kernel 11:platform: NXP 11:area: Drivers 10:area: ARM 9:platform: ESP32 9:area: Xtensa 8:area: Documentation 7:area: Watchdog 7:area: Shell 7:area: Samples 7:area: Memory Protection 6:area: Sockets 5:area: USB 5:area: Toolchains 5:area: I2C 4:area: Power Management 4:area: POSIX 4:area: File System 3:area: west 3:area: UART 3:area: Timer 3:area: Tests 3:area: PWM 3:area: NIOS2 3:area: Device Tree 3:area: Counter 3:API 2:platform: STM32 2:good first issue 2:area: X86 2:area: Testing 2:area: Security 2:area: Sanitycheck 2:area: SPI 2:area: Portability 2:area: Other 2:area: GPIO 2:area: Conformance 2:area: C Library 2:area: Boards 2:area: ARC 1:to do 1:platform: SiLabs 1:platform: ATMEL 1:area: mcumgr 1:area: Testing Suite 1:area: PCI 1:area: OpenThread 1:area: OTA 1:area: LWM2M 1:area: Kconfig 1:area: IPC 1:area: Flash 1:area: Ethernet 1:area: Display 1:area: Debugging 1:area: Crypto / RNG 1:area: Console 1:area: Configuration System 1:area: Build System 1:Security Review 1:LTS 1:EXT
|
|
|
|
Re: Get RSSI in DTM(Zephyr)
Ryan Erickson
Hello Tommy,
You can look at the Bluetooth specification to learn more about DTM mode. I do not have any code or documents to share. You will have to dig into the zephyr source code to see how you can implement your own DTM command to give you RSSI.
Ryan Erickson | Software Development Engineer III Laird Connectivity
From: Tommy Lin (林志聰) <Tommy.Lin@...>
Sent: Wednesday, February 20, 2019 19:17 To: Ryan Erickson <Ryan.Erickson@...>; Jamie Mccrae <Jamie.Mccrae@...>; Isaac Chen (陳尚航) <Isaac_Chen@...>; Chettimada, Vinayak Kariappa <vinayak.kariappa.chettimada@...>; zephyr-devel@... Cc: Hanyu.Hsu@...; Rung-Sheng Lee (李榮盛) <Rung.Sheng.Lee@...>; Brent Tsai (蔡旻其) <Brent.Tsai@...>; Ryan Hsu (徐振鋒) <Ryan.Hsu@...> Subject: RE: [Zephyr-devel] Get RSSI in DTM(Zephyr)
EXTERNAL EMAIL: This email originated outside of Laird. Be careful with attachments and links. Hi Ryan Erickson, We would greatly appreciate it if you kindly give me some suggestions on the case. For example , What documents we can reference? Where can we find some relevant code?
Thanks Tommy From: Tommy Lin (林志聰)
Hi Ryan, Thanks for your response.
Could you share if there are any reference code for DTM RSSI.
Thank You, Tommy From: Ryan Erickson [mailto:Ryan.Erickson@...]
Hello Tommy,
Per the Bluetooth Spec, there are no DTM commands to obtain RSSI. You would need to add your own custom command in firmware.
Regards,
Ryan Erickson | Software Development Engineer III Laird Connectivity
From:
devel@... <devel@...>
On Behalf Of Tommy Lin (???)
EXTERNAL EMAIL: This email originated outside of Laird. Be careful with attachments and links. Hi Jamie, Sorry to bother you. I use hci command LE Receiver Test Command and LE Test End Command let DUT enter Test mode and can get packets from equipment successfully. Equipment send 1500 Bytes with RSSI(70 dbm) to DUT
At the same time , I try to launch “btmon” tool to get RSSI information , but I can’t get any RSSI.
Are there any methods can get RSSI in DTM?
Thanks Tommy From: Jamie Mccrae [mailto:Jamie.Mccrae@...]
Hi Isaac, Generally you would be measuring the RSSI on the test equipment from a signal generated by your Bluetooth radio, and would be using a calibrated accurate test system. The nRF51824 (from the product spec) has an RSSI accuracy of +/-6dB, that is wildly inaccurate and I cannot see any reason to want to measure/record it on every module. You can add a non-standard command to read and return the RSSI if needed to the DTM code. Thanks, Jamie
From:
devel@... [mailto:devel@...]
On Behalf Of Isaac Chen (???)
Hi Vinayak,
Our customer requested us to test conductive BLE RSSI in factory for accuracy improvement. Could you please clarify the following questions?
In our experiences of other algorithm(LTE/WCDMA…etc.), RSSI usually can be detected easily in test mode via a CW tone. So it’s why we want to double check this.
Best Regards
Isaac Chen Quanta Computer Inc. Business Unit 11 BL1 Tel : +886-3-327-2345 Ext : 17585
This transmission is intended only for the use of the addressed recipient and may contain information that is privileged, confidential and exempt from disclosure under applicable law. If you are not the intended recipient, any use of this communication is strictly prohibited. If you have received this communication in error, please kindly notify the sender and delete this message immediately.
From: Chettimada, Vinayak Kariappa [mailto:vinayak.kariappa.chettimada@...]
Hi Tommy,
I don’t remember if DTM mode has any RSSI command in the Specification.
Could you please elaborate on your requirements?
Regards, Vinayak
From:
devel@... <devel@...>
On Behalf Of Tommy Lin (???)
Hi , We have a product using nRF51824 with zephyr. We use hci_uart sample code and follow below link , and we can get other BT device’s RSSI. https://devzone.nordicsemi.com/b/blog/posts/nrf5x-support-within-the-zephyr-project-rtos
We have a question , If it is in DTM(Direct Test Mode) , how can we get RSSI? Could you give us some suggestions.
Best regards, Tommy
|
|
|
|
Carles Cufi
Hi Ryan,
The UART driver itself uses the GPIO driver internally so I don’t think there should be any issues with your usecase.
Regards,
Carles
From:
<devel@...> on behalf of Ryan Erickson <ryan.erickson@...>
Hello,
|
|
|
|
Re: Get RSSI in DTM(Zephyr)
Tommy Lin (林志聰) <Tommy.Lin@...>
Hi Ryan Erickson, We would greatly appreciate it if you kindly give me some suggestions on the case. For example , What documents we can reference? Where can we find some relevant code?
Thanks Tommy
From: Tommy Lin (林志聰)
Sent: Tuesday, February 19, 2019 10:12 AM To: 'Ryan Erickson' <Ryan.Erickson@...>; Jamie Mccrae <Jamie.Mccrae@...>; Isaac Chen (陳尚航) <Isaac_Chen@...>; Chettimada, Vinayak Kariappa <vinayak.kariappa.chettimada@...>; zephyr-devel@... Cc: Hanyu.Hsu@...; Rung-Sheng Lee (李榮盛) <Rung.Sheng.Lee@...>; Brent Tsai (蔡旻其) <Brent.Tsai@...>; Ryan Hsu (徐振鋒) <Ryan.Hsu@...> Subject: RE: [Zephyr-devel] Get RSSI in DTM(Zephyr)
Hi Ryan, Thanks for your response.
Could you share if there are any reference code for DTM RSSI.
Thank You, Tommy From: Ryan Erickson [mailto:Ryan.Erickson@...]
Hello Tommy,
Per the Bluetooth Spec, there are no DTM commands to obtain RSSI. You would need to add your own custom command in firmware.
Regards,
Ryan Erickson | Software Development Engineer III Laird Connectivity
From:
devel@... <devel@...>
On Behalf Of Tommy Lin (???)
EXTERNAL EMAIL: This email originated outside of Laird. Be careful with attachments and links. Hi Jamie, Sorry to bother you. I use hci command LE Receiver Test Command and LE Test End Command let DUT enter Test mode and can get packets from equipment successfully. Equipment send 1500 Bytes with RSSI(70 dbm) to DUT
At the same time , I try to launch “btmon” tool to get RSSI information , but I can’t get any RSSI.
Are there any methods can get RSSI in DTM?
Thanks Tommy From: Jamie Mccrae [mailto:Jamie.Mccrae@...]
Hi Isaac, Generally you would be measuring the RSSI on the test equipment from a signal generated by your Bluetooth radio, and would be using a calibrated accurate test system. The nRF51824 (from the product spec) has an RSSI accuracy of +/-6dB, that is wildly inaccurate and I cannot see any reason to want to measure/record it on every module. You can add a non-standard command to read and return the RSSI if needed to the DTM code. Thanks, Jamie
From:
devel@... [mailto:devel@...]
On Behalf Of Isaac Chen (???)
Hi Vinayak,
Our customer requested us to test conductive BLE RSSI in factory for accuracy improvement. Could you please clarify the following questions? 1. As I know, BLE RSSI can’t be measured in standard DTM mode. Is it possible to add new feature in DTM to support BLE RSSI measurement? 2. If the answer to the above question is “no”, I still need your confirmation if other test modes exist that can measure RSSI except DTM mode. In our experiences of other algorithm(LTE/WCDMA…etc.), RSSI usually can be detected easily in test mode via a CW tone. So it’s why we want to double check this. 3. Do you have any customers who have experiences to measure conductive RSSI in factory or in lab? If so, can you share the methodology?
Best Regards
Isaac Chen Quanta Computer Inc. Business Unit 11 BL1 Tel : +886-3-327-2345 Ext : 17585
This transmission is intended only for the use of the addressed recipient and may contain information that is privileged, confidential and exempt from disclosure under applicable law. If you are not the intended recipient, any use of this communication is strictly prohibited. If you have received this communication in error, please kindly notify the sender and delete this message immediately.
From: Chettimada, Vinayak Kariappa [mailto:vinayak.kariappa.chettimada@...]
Hi Tommy,
I don’t remember if DTM mode has any RSSI command in the Specification.
Could you please elaborate on your requirements?
Regards, Vinayak
From:
devel@... <devel@...>
On Behalf Of Tommy Lin (???)
Hi , We have a product using nRF51824 with zephyr. We use hci_uart sample code and follow below link , and we can get other BT device’s RSSI. https://devzone.nordicsemi.com/b/blog/posts/nrf5x-support-within-the-zephyr-project-rtos
We have a question , If it is in DTM(Direct Test Mode) , how can we get RSSI? Could you give us some suggestions.
Best regards, Tommy
|
|
|
|
Ryan Erickson
Hello,
I am using the NRF52840, UART1 with hardware flow control turned on. I want to be able to detect transitions on the CTS pin (input). Currently I tried using the GPIO driver to configure interrupts on both edges and this seems to work great for monitoring the CTS pin state. Is it alright to use the GPIO driver to do this when the UART peripheral is using that IO as well? I am looking for confirmation that this should work and not cause me any issues. Thanks, Ryan
|
|
|
|
Re: Zephyr SDK 0.10.0-rc2 available
Henrik Brix Andersen
Hi,
On 20 Feb 2019, at 17.08, Kumar Gala <kumar.gala@linaro.org> wrote:Great! That should be enough. I had a couple of issues with openocd on an RV32M1 earlier on. The issue was related to selecting the boot mode and then flashing an application, , but I cannot reproduce it now with -rc2. Thanks, Brix -- Henrik Brix Andersen
|
|
|
|
Re: Zephyr SDK 0.10.0-rc2 available
Kumar Gala
I pulled in some patches for openocd:
toggle quoted messageShow quoted text
https://github.com/zephyrproject-rtos/openocd/commit/3f1f90b7cfc5ae0e3f0b17d0f0cf876ee5981e8f https://github.com/zephyrproject-rtos/openocd/commit/d34bc2055d3d749c3176a20541e4296a44ed1fa2 Any other changes we need? - k
On Feb 20, 2019, at 10:03 AM, Henrik Brix Andersen <henrik@brixandersen.dk> wrote:
|
|
|