|
Re: MISRA
Let me talk clear: in the portion of Zephyr currently checked we have more than 18K violations of what I think is one of the most valuable rule of BARR C that asks that any non obviously
Let me talk clear: in the portion of Zephyr currently checked we have more than 18K violations of what I think is one of the most valuable rule of BARR C that asks that any non obviously
|
By
Abramo Bagnara
·
#8268
·
|
|
Re: MISRA
After taking a look at https://github.com/zephyrproject-rtos/zephyr/pull/41227 I fully agree with Nicolas and honestly I hate this more than I could have possibly imagined before.
The code is now
After taking a look at https://github.com/zephyrproject-rtos/zephyr/pull/41227 I fully agree with Nicolas and honestly I hate this more than I could have possibly imagined before.
The code is now
|
By
Carlo Caione
·
#8267
·
|
|
Re: MISRA
Let resume state after commit with the points still to be decided, so we can be more specific and finalize:
- 0 is success, non-zero is error: the comunity agrees to change to have
- Z_OOPS takes an
Let resume state after commit with the points still to be decided, so we can be more specific and finalize:
- 0 is success, non-zero is error: the comunity agrees to change to have
- Z_OOPS takes an
|
By
Abramo Bagnara
·
#8266
·
|
|
Re: MISRA
Wow! OK... I see that this fu^H^Hmixed-up convention already exists in
the tree today. You simply followed that precedent.
[...]
* @return False on success, True on failure
*/
#define
Wow! OK... I see that this fu^H^Hmixed-up convention already exists in
the tree today. You simply followed that precedent.
[...]
* @return False on success, True on failure
*/
#define
|
By
Nicolas Pitre
·
#8265
·
|
|
Re: MISRA
I think you have noted that at least another member has presented some objections.
Which strategies the comunity have adopted in similar cases to obtain a fast convergence and to avoid
I think you have noted that at least another member has presented some objections.
Which strategies the comunity have adopted in similar cases to obtain a fast convergence and to avoid
|
By
Abramo Bagnara
·
#8264
·
|
|
Re: MISRA
I think <sys/util.h> would be a good place.
Please make it into a fetchable branch. That'd make my reviewing easier.
Nicolas
I think <sys/util.h> would be a good place.
Please make it into a fetchable branch. That'd make my reviewing easier.
Nicolas
|
By
Nicolas Pitre
·
#8263
·
|
|
Cancelled Event: Zephyr: Power Management Sync - Thursday, December 30, 2021
#cal-cancelled
Cancelled: Zephyr: Power Management Sync
This event has been cancelled.
When:
Thursday, December 30, 2021
11:00am to 12:00pm
(UTC-08:00) America/Los Angeles
Where:
Microsoft Teams
Organizer:
Cancelled: Zephyr: Power Management Sync
This event has been cancelled.
When:
Thursday, December 30, 2021
11:00am to 12:00pm
(UTC-08:00) America/Los Angeles
Where:
Microsoft Teams
Organizer:
|
By
devel@lists.zephyrproject.org Calendar <noreply@...>
·
#8262
·
|
|
Cancelled Event: Zephyr: Power Management Sync - Thursday, December 23, 2021
#cal-cancelled
Cancelled: Zephyr: Power Management Sync
This event has been cancelled.
When:
Thursday, December 23, 2021
11:00am to 12:00pm
(UTC-08:00) America/Los Angeles
Where:
Microsoft Teams
Organizer:
Cancelled: Zephyr: Power Management Sync
This event has been cancelled.
When:
Thursday, December 23, 2021
11:00am to 12:00pm
(UTC-08:00) America/Los Angeles
Where:
Microsoft Teams
Organizer:
|
By
devel@lists.zephyrproject.org Calendar <noreply@...>
·
#8261
·
|
|
Cancelled Event: Zephyr: Power Management Sync - Thursday, December 16, 2021
#cal-cancelled
Cancelled: Zephyr: Power Management Sync
This event has been cancelled.
When:
Thursday, December 16, 2021
11:00am to 12:00pm
(UTC-08:00) America/Los Angeles
Where:
Microsoft Teams
Organizer:
Cancelled: Zephyr: Power Management Sync
This event has been cancelled.
When:
Thursday, December 16, 2021
11:00am to 12:00pm
(UTC-08:00) America/Los Angeles
Where:
Microsoft Teams
Organizer:
|
By
devel@lists.zephyrproject.org Calendar <noreply@...>
·
#8260
·
|
|
Event: Zephyr: Power Management Sync - 12/16/2021
#cal-reminder
Reminder: Zephyr: Power Management Sync
When:
12/16/2021
11:00am to 12:00pm
(UTC-08:00) America/Los Angeles
Where:
Microsoft Teams
Organizer: devel@...
An RSVP is requested. Click here to
Reminder: Zephyr: Power Management Sync
When:
12/16/2021
11:00am to 12:00pm
(UTC-08:00) America/Los Angeles
Where:
Microsoft Teams
Organizer: devel@...
An RSVP is requested. Click here to
|
By
devel@lists.zephyrproject.org Calendar <noreply@...>
·
#8259
·
|
|
Re: MISRA
Hi Abramo,
I think Nicolas makes some good points here.
Zephyr code is too different from Linux style for my liking, e.g. the
strange {} around single-line statements.
Things like 'if (rc != 0)'
Hi Abramo,
I think Nicolas makes some good points here.
Zephyr code is too different from Linux style for my liking, e.g. the
strange {} around single-line statements.
Things like 'if (rc != 0)'
|
By
Simon Glass <sjg@...>
·
#8258
·
|
|
Event: Zephyr Project: Dev Meeting - 12/16/2021
#cal-reminder
Reminder: Zephyr Project: Dev Meeting
When:
12/16/2021
8:00am to 9:00am
(UTC-08:00) America/Los Angeles
Where:
Microsoft Teams Meeting
Organizer: devel@...
An RSVP is requested. Click here
Reminder: Zephyr Project: Dev Meeting
When:
12/16/2021
8:00am to 9:00am
(UTC-08:00) America/Los Angeles
Where:
Microsoft Teams Meeting
Organizer: devel@...
An RSVP is requested. Click here
|
By
devel@lists.zephyrproject.org Calendar <noreply@...>
·
#8257
·
|
|
Re: MISRA
Unless we find a good place for this macro I'd be forced to leave double cast. If it is preferred I can add a line of documentation before each occurence.
I'd like very much you take a look
Unless we find a good place for this macro I'd be forced to leave double cast. If it is preferred I can add a line of documentation before each occurence.
I'd like very much you take a look
|
By
Abramo Bagnara
·
#8256
·
|
|
Dev-review Agenda (Dec 16, 2021)
Agenda for this week's Dev-Review meeting:
Add iomux rt driver
- https://github.com/zephyrproject-rtos/zephyr/pull/40880
shields: add generic shield to use CDC ACM UART as backend
-
Agenda for this week's Dev-Review meeting:
Add iomux rt driver
- https://github.com/zephyrproject-rtos/zephyr/pull/40880
shields: add generic shield to use CDC ACM UART as backend
-
|
By
Kumar Gala
·
#8255
·
|
|
Re: MISRA
Absolutely! This is a great example of papering over what is most likely
a flaw in the code. Instead of questioning the fundamental of such
non-preserving conversion, the added cast gives the
Absolutely! This is a great example of papering over what is most likely
a flaw in the code. Instead of questioning the fundamental of such
non-preserving conversion, the added cast gives the
|
By
Nicolas Pitre <nico@...>
·
#8254
·
|
|
Re: MISRA
Are you really arguing that a commented explicit cast (for non obviously value-preserving conversion) is worse than an implicit cast?
Are you taking in account that although you can write tests for
Are you really arguing that a commented explicit cast (for non obviously value-preserving conversion) is worse than an implicit cast?
Are you taking in account that although you can write tests for
|
By
Abramo Bagnara
·
#8253
·
|
|
Re: MISRA
I appreciate your points, and similarly for a few others before yours,
but I think they are missing the point.
No one is against virtue.
Everybody wants the code base to be more consistent, more
I appreciate your points, and similarly for a few others before yours,
but I think they are missing the point.
No one is against virtue.
Everybody wants the code base to be more consistent, more
|
By
Nicolas Pitre <nico@...>
·
#8252
·
|
|
Re: MISRA
Hi,
I've written this email two days ago and somehow it never left my
outbox so I'm re-sending it because I think it is still relevant.
We should keep this discussion as much technical as possible.
Hi,
I've written this email two days ago and somehow it never left my
outbox so I'm re-sending it because I think it is still relevant.
We should keep this discussion as much technical as possible.
|
By
Flavio Ceolin
·
#8251
·
|
|
Re: MISRA
A few points from my side (probably nothing that has not been already said)
MISRA mostly tries to avoid undefined behavior derived issues. Other languages such as Rust have done a better job on this
A few points from my side (probably nothing that has not been already said)
MISRA mostly tries to avoid undefined behavior derived issues. Other languages such as Rust have done a better job on this
|
By
Gerard Marull Paretas
·
#8250
·
|
|
Re: MISRA
Olof,
Point taken, will start posting agenda the day before.
Anas
From: devel@... <devel@...> on behalf of Olof Johansson <olof@...>
Date: Wednesday, December 15, 2021 at 2:14 AM
To: Hibberd,
Olof,
Point taken, will start posting agenda the day before.
Anas
From: devel@... <devel@...> on behalf of Olof Johansson <olof@...>
Date: Wednesday, December 15, 2021 at 2:14 AM
To: Hibberd,
|
By
Nashif, Anas
·
#8249
·
|