Reminder: Zephyr Project: Dev Meeting

When:
10/28/2021
3:00pm to 4:00pm
(UTC+00:00) UTC

Where:
Microsoft Teams Meeting

Organizer: devel@...

An RSVP is requested. Click here to RSVP

Description:

Reminder: Zephyr Project: APIs

When:
10/26/2021
4:00pm to 5:00pm
(UTC+00:00) UTC

Where:
Microsoft Teams Meeting

Organizer: devel@...

An RSVP is requested. Click here to RSVP

Description:

Hi all,

Agenda for today:

- RFC: API Change: Device Tree change for ranges property handling
- https://github.com/zephyrproject-rtos/zephyr/issues/39464

- PM structure optimization: Update
- Issue: https://github.com/zephyrproject-rtos/zephyr/issues/39286
- PR (option 4): https://github.com/zephyrproject-rtos/zephyr/pull/39397

Time permitting, we can continue with pinctrl.

- Pinctrl: Now focusing on #37572 as the single PR to target our efforts
- API, tests & docs: https://github.com/zephyrproject-rtos/zephyr/pull/37572
- nRF implementation: https://github.com/zephyrproject-rtos/zephyr/pull/39429
- STM32 port: https://github.com/zephyrproject-rtos/zephyr/pull/39430
- Discussion, specifically Devicetree layout format: https://github.com/zephyrproject-rtos/zephyr/discussions/35077#discussioncomment-1201394

If you have additional items please let me know.

Teams link: https://teams.microsoft.com/l/meetup-join/19%3ameeting_NWU2MjZlYWEtZDcwMi00MWQzLTgwMjEtNDdkYjQwMjBjMmFj%40thread.v2/0?context=%7b%22Tid%22%3a%22af0096d9-700c-411a-b795-b3dd7122bad2%22%2c%22Oid%22%3a%22841a7c92-7816-4faf-9887-5e334e88f6d8%22%7d

https://lists.zephyrproject.org/g/devel/calendar
https://github.com/zephyrproject-rtos/zephyr/projects/18

Minutes:
https://docs.google.com/document/d/1lv-8B5QE2m4FjBcvfqAXFIgQfW5oz6306zJ7GIZIWCk/edit

Regards,

Reminder: Zephyr Memory Footprint - biweekly discussion

When:
10/25/2021
3:00pm to 4:00pm
(UTC+00:00) UTC

Where:
Microsoft Teams Meeting

Organizer: devel@...

An RSVP is requested. Click here to RSVP

Description:
Working doc: https://docs.google.com/document/d/1bnQLJKVhgI3zkk3MsSXun8onEsA8z1Rf5ohdbCHASmU/edit#heading=h.x36xe8bnwr9r

Hi Johann, thanks for the reply!

>> There are a few of reasons why having this feature would be nice:
>> - As of now, it seems that the full Modbus spec isn't implemented and
>> this would allow end users to work around that, if necessary.
>> - Modbus has specific function ranges for user defined features.
>> - Since Modbus is easy to extend, it's not uncommon to do so.

> There is a mandatory function from the spec that is not implemented? Which one?

Well, depends on how you look at it whether you'd consider it
mandatory. The spec
https://www.modbus.org/docs/Modbus_Application_Protocol_V1_1b3.pdf
section 5 p. 10 says that there are specific ranges of user-defined
function codes whose implementation is left to the vendor, referring
to device manufacturers. The existence of said ranges probably doesn't
count as a mandatory requirement for the software stack provider (in
this case Zephyr), but device vendors might consider it a requirement
when selecting a stack. Anyway, it's a nice feature to have.

> It could work, struct modbus_server_param should also be changed accordingly.
> And we would need test for this functionality.

I was originally thinking of adding a new API function in the lines of modbus_register_function(),
but adding a pointer to modbus_server_param is arguably simpler.

I haven't had the time to dig into the testing side of Zephyr. I guess the tests are written against QEMU?
If so, I might try to add a few tests next.

Btw, what's your preferred workflow with GitHub PRs? Mainly, should I open an issue before creating
a PR and who to add as reviewers? I scanned the maintainers file but couldn't find a suitable
section for Modbus.

Reminder: Zephyr: Power Management Sync

When:
10/21/2021
6:00pm to 7:00pm
(UTC+00:00) UTC

Where:
Microsoft Teams

Organizer: devel@...

An RSVP is requested. Click here to RSVP

Description:

Cancelled: Zephyr Project: Dev Meeting

This event has been cancelled.

When:
Thursday, October 21, 2021
3:00pm to 4:00pm
(UTC+00:00) UTC

Where:
Microsoft Teams Meeting

Organizer: devel@...

Description:

Zephyr: Power Management Sync

When:
Thursday, October 21, 2021
6:00pm to 7:00pm
(UTC+00:00) UTC
Repeats: Weekly on Thursday

Where:
Microsoft Teams

Organizer: devel@...

An RSVP is requested. Click here to RSVP

Description:

Cancelled: Zephyr Project: Dev Meeting

This event has been cancelled.

When:
Thursday, November 25, 2021
3:00pm to 4:00pm
(UTC+00:00) UTC

Where:
Microsoft Teams Meeting

Organizer: devel@...

Description:

Cancelled: Zephyr Project: Dev Meeting

This event has been cancelled.

When:
Thursday, November 4, 2021
3:00pm to 4:00pm
(UTC+00:00) UTC

Where:
Microsoft Teams Meeting

Organizer: devel@...

Description:

Hi,

Am 16.10.2021 20:43 schrieb Henrik Lindblom:

Hi!
I was wondering if there's any work being done to allow users to
extend Modbus by defining their own function codes (and handlers to
those)?

not yet.

I looked at the implementation in 2.6.0 and there is
MODBUS_RAW which sort of allows the user to define a callback to
handle arbitrary ADUs, but this is only for TCP (not really sure as to
why the limitation, though).

It is not limited to TCP and allows to use any transport backend than UART.
It is actually other end of the system.

I was tinkering around the codebase and
figured it would be easy enough to augment struct modbus_context to
include a list of user provided extensions that are tried if the PDU
has an unknown function code.

It could work, struct modbus_server_param should also be changed accordingly.
And we would need test for this functionality.

There are a few of reasons why having this feature would be nice:
- As of now, it seems that the full Modbus spec isn't implemented and
this would allow end users to work around that, if necessary.
- Modbus has specific function ranges for user defined features.
- Since Modbus is easy to extend, it's not uncommon to do so.

There is a mandatory function from the spec that is not implemented? Which one?

I implemented a quick hack which I'm still testing, but one thing that
I find a bit redundant in my approach is that MODBUS_RAW already
implements *almost* this functionality. The drawback IMO is that it
only allows a single callback to be defined, which ~works, but doesn't
allow users to benefit from the existing handler code, and makes the
API / Kconfig more confusing. I at least had no clue what MODBUS_RAW
was until I looked at the code. The optimal solution would be to
combine these two and remove the TCP only -restriction from
MODBUS_RAW.

As said MODBUS_RAW is another side of the system and has nothing to do with "FC handling" directly.

Johann

Reminder: Zephyr Project: APIs

When:
10/19/2021
4:00pm to 5:00pm
(UTC+00:00) UTC

Where:
Microsoft Teams Meeting

Organizer: devel@...

An RSVP is requested. Click here to RSVP

Description:

Oops, sorry about the bad formatting, the correct link is https://github.com/zephyrproject-rtos/zephyr/discussions/39437

Anas

On 2021-10-18, 4:36 PM, "devel@... on behalf of Nashif, Anas" <devel@... on behalf of anas.nashif@...> wrote:

Hello,

The changes below will take effect today. If you are a Zephyr project collaborator or maintainer and notice that your access was downgraded, then make sure your github name is in the MAINTAINERS.yml file and check your inbox for team invites from the zephyr project and accept those.

This topic was added to GH discussions, for any comments, feedback or complaints please use:

https://github.com/zephyrproject-rtos/zephyr/discussions/39437 <https://github.com/zephyrproject-rtos/zephyr/discussions/39437</div><div><br></div><div>    Thanks,</div><div>    Anas</div><div><br></div><div><br></div><div>    On>

    Thanks, <https://github.com/zephyrproject-rtos/zephyr/discussions/39437</div><div><br></div><div>    Thanks,</div><div>    Anas</div><div><br></div><div><br></div><div>    On>
    Anas <https://github.com/zephyrproject-rtos/zephyr/discussions/39437</div><div><br></div><div>    Thanks,</div><div>    Anas</div><div><br></div><div><br></div><div>    On>

Hello,

The changes below will take effect today. If you are a Zephyr project collaborator or maintainer and notice that your access was downgraded, then make sure your github name is in the MAINTAINERS.yml file and check your inbox for team invites from the zephyr project and accept those.

This topic was added to GH discussions, for any comments, feedback or complaints please use:

https://github.com/zephyrproject-rtos/zephyr/discussions/39437

Thanks,
Anas


On 2021-10-14, 8:31 AM, "devel@... on behalf of Nashif, Anas" <devel@... on behalf of anas.nashif@...> wrote:

Hello everyone,

We recently made changes to the project roles and the access levels given to contributors on github. Please refer to the full documentation of the roles below for more details:

https://docs.zephyrproject.org/latest/development_process/project_roles.html <https://docs.zephyrproject.org/latest/development_process/project_roles.html</div><div><br></div><div>    The>

    The <https://docs.zephyrproject.org/latest/development_process/project_roles.html</div><div><br></div><div>    The> summary of the changes:

- Contributors are initially only given Read access to the Zephyr GitHub repository. Specifically, at the Read access level, Contributors are not allowed to assign reviewers to their own pull requests. An automated process will assign reviewers.
- Contributors who show dedication and skill are granted the Github Triage permission[1] level to the Zephyr GitHub repository. You may nominate yourself, or another GitHub user, for promotion to the Github Triage permission level by creating a GitHub issue, using the nomination issue type: Go to Issues, click on “New Issue” and select “Contributor Nomination” issue type, submit the issue and wait for it to be processed.
- Contributors granted the Github Triage permission level are permitted to add reviewers to a pull request and can be added as a reviewer by other GitHub users. Contributor votes on pull requests are not counted with respect to accepting and merging a pull request. However, Contributors comments and requested changes should still be considered by the pull request author.
- Contributors are promoted to the Collaborator role by adding the GitHub user name to one or more collaborators sections of the MAINTAINERS File in the Zephyr repository. Collaborator votes on pull requests can block or approve the pull request.

Many new contributors already had the same access as “Collaborators” (Write access). This access will be reset and only collaborators and maintainers referenced in the MAINTAINER file will have write access now.

If you notice that you do not have the same access as before, then most likely you are not in the MAINTAINER file. You will need to add yourself to the MAINTAINER file in the areas you are most active in using a pull request, once merged and approved, you will be assigned the collaborator access level.


This change will take effect Monday, October 18th.

If you have any concerns or questions, please reply to this email or use discord.

Thank you,

Anas


[1] https://docs.github.com/en/organizations/managing-access-to-your-organizations-repositories/repository-permission-levels-for-an-organization <https://docs.github.com/en/organizations/managing-access-to-your-organizations-repositories/repository-permission-levels-for-an-organization</div><div><br></div><div><br></div><div><br></div><div>

Hi all,

Agenda for tomorrow:

- PM structure optimization
- Issue: https://github.com/zephyrproject-rtos/zephyr/issues/39286
- PR (option 4): https://github.com/zephyrproject-rtos/zephyr/pull/39397

Time permitting, we can continue with pinctrl.

- Pinctrl: Now focusing on #37572 as the single PR to target our efforts
- API, tests & docs: https://github.com/zephyrproject-rtos/zephyr/pull/37572
- nRF implementation: https://github.com/zephyrproject-rtos/zephyr/pull/39429
- STM32 port: https://github.com/zephyrproject-rtos/zephyr/pull/39430
- Discussion, specifically Devicetree layout format: https://github.com/zephyrproject-rtos/zephyr/discussions/35077#discussioncomment-1201394

If you have additional items please let me know.

Teams link: https://teams.microsoft.com/l/meetup-join/19%3ameeting_NWU2MjZlYWEtZDcwMi00MWQzLTgwMjEtNDdkYjQwMjBjMmFj%40thread.v2/0?context=%7b%22Tid%22%3a%22af0096d9-700c-411a-b795-b3dd7122bad2%22%2c%22Oid%22%3a%22841a7c92-7816-4faf-9887-5e334e88f6d8%22%7d

https://lists.zephyrproject.org/g/devel/calendar
https://github.com/zephyrproject-rtos/zephyr/projects/18

Minutes:
https://docs.google.com/document/d/1lv-8B5QE2m4FjBcvfqAXFIgQfW5oz6306zJ7GIZIWCk/edit

Regards,

Carles

Zephyr: Toolchain Working Group

When:
10/18/2021
3:00pm to 4:00pm
(UTC+00:00) UTC

Where:
Microsoft Teams Meeting

Organizer: Torsten Rasmussen

Description: