|
Re: MISRA-C and Zephyr
Jiří Kubias
Hi, I have one practical question regarding MISRA-C standard. Where I can get the standard as a regular coder? I can buy one for £15 + VAT, but I dont thing that every body want to buy it. Is there any public description of this standard? There are many of us who never met with MISRA standard. Regards, Jiri Kubias 2018-09-16 23:20 GMT+02:00 Flavio Ceolin <flavio.ceolin@...>:
Hi Reto, --
===================================================
Ing. Jiri Kubias e-mail: jiri.kubias@... mobile: 775 593 956 ===================================================
|
|
|
|
Re: MPU fault while testing Bluetooth Mesh Sample demos
Jiří Kubias
Hi, have you found a solution? Few days ago I have reported similar problem with MPU fault but with Atmel (Microchip) SAME70 chip. It is cased by binding DMA. dev_cfg->dev_dma = device_get_binding(CONFIG_SPI_ if (!dev_cfg->dev_dma) { SYS_LOG_ERR("%s device not found", CONFIG_SPI_SAM_DMA_NAME); return -ENODEV; } and the console output is ***** MPU FAULT ***** Data Access Violation MMFAR Address: 0x412198 ***** Hardware exception ***** Current thread ID = 0x204024b4 Faulting instruction address = 0x40e376 Fatal fault in essential thread! Spinning... So far I didnt solved the issue, but I didnt had a much time to debug it. Best regards, Jiri 2018-09-14 12:33 GMT+02:00 vikrant8051 <vikrant8051@...>:
--
===================================================
Ing. Jiri Kubias e-mail: jiri.kubias@... mobile: 775 593 956 ===================================================
|
|
|
|
Re: Application specific MBEDTLS configuration
Flavio Ceolin
Hi,
Hi,Agree, it's worth to fill an issue regarding this. Regards, Flavio Ceolin
|
|
|
|
Re: Application specific MBEDTLS configuration
Aurelien Jarno
Hi,
On 2018-09-16 12:25, Flavio Ceolin wrote: HI Aurelien,Yes, it indeed works that way. That said I don't consider that as aHi all,Have you tried to pass the absolute path of your header in solution. The value in the Kconfig file comes from the app's prj.conf and I don't want to hard-code the path there. I would like to be able to distribute the app that people can then build it against Zephyr, in the directory they want. Regards, Aurelien -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://www.aurel32.net
|
|
|
|
Re: MISRA-C and Zephyr
Flavio Ceolin
Hi Reto,
On 09/15/2018 06:07 AM, Kumar Gala wrote:Yeah, last time I've checked it was requiring the MISRA-C standardNot support MISRA directly, but I assume we can implement the MISRA checks either by configuring specific rules of cppcheck or implementing our own. If there’s some MISRA checker out there, even better.Cppcheck has some MISRAC C 2012 checks for a while now [1]. converted to a pure text. The problem is that we can distribute MISRA-C. Though, I'll check if the standard is only required for pretty-print the errors. Good to know :) Regards, Flavio Ceolin
|
|
|
|
Re: Application specific MBEDTLS configuration
Flavio Ceolin
HI Aurelien,
Hi all,Have you tried to pass the absolute path of your header in MBEDTLS_CFG_FILE ? Regards, Flavio Ceolin
|
|
|
|
Re: MISRA-C and Zephyr
Flavio Ceolin
Hi Himanshu,
Hello Flavio,Agree, we'll never put any compliance claim based on Coccinelle, even because to this *much likely* we have to use a qualified tool. Nevertheless, there are rules that we can't even check with Coccinelle. My idea is using Coccinelle as a best effort with other tools to enforce as much as possible MISRA-C guidelines. Yeah, that is really what I had in mind. Currently I'm using coccinelle where I can but I'm still reviewing the output manually. Good !
Thanks a lot for you work on coccinelle and Zephyr, I certainly will ping you with more questions :) Regards, Flavio Ceolin
|
|
|
|
Application specific MBEDTLS configuration
Aurelien Jarno
Hi all,
I have specific needs for my application and I would therefore like to provide my own mbedtls config file or extend an existing one. The existing MBEDTLS_CFG_FILE seems to only be able to use files in the zephyr source code (as opposed to the app source code). The recently added generic TLS configuration allow to specific an additional include file through the TLS_USER_CONFIG_FILE option, but it seems to suffer from the same issue. Does anyone have a trick to provide an application specific mbedtls config file? Thanks, Aurelien -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://www.aurel32.net
|
|
|
|
Re: MISRA-C and Zephyr
Reto Schneider
On 09/15/2018 06:07 AM, Kumar Gala wrote:
Not support MISRA directly, but I assume we can implement the MISRA checks either by configuring specific rules of cppcheck or implementing our own. If there’s some MISRA checker out there, even better.Cppcheck has some MISRAC C 2012 checks for a while now [1]. Also, it is quite simple to add such checks to clang-tidy [2]. I am no longer working in a safety relevant area, so I did not push this pet project in the past, but extending it for Zephyrs needs would probably be a good reason to do so. [1] http://cppcheck.net/misra.php [2] https://github.com/rettichschnidi/clang-tidy-misra Kind regards, Reto
|
|
|
|
Re: MISRA-C and Zephyr
Himanshu Jha <himanshujha199640@...>
Hello Flavio,
On Fri, Sep 14, 2018 at 11:19:40PM -0700, Flavio ceolin wrote: Agree, we have to automate it as much as possible. But we can't just waitThanks for using Coccinelle for the memset cleanup! Coccinelle can handle MISRA-C compliance at some extent and it really depends on the what you wish to accomplish through a coccinelle script. Some scripts are easy to write, but certainly we can't claim to write scripts with 0% false positives. It depends upon the problem set and how well you design a cocci script. For instance: We planned to remove the unnecessary casts returned by memory allocating functions *alloc since we know the conversion from void* and other type is implicit. https://github.com/torvalds/linux/blob/master/scripts/coccinelle/api/alloc/alloc_cast.cocci But while working and testing the script, I found some strange code where the cast was necessary and removing it would be a regression: drivers/scsi/fnic/fnic_trace.c <snip> static unsigned long fnic_trace_buf_p; ... fnic_trace_buf_p = (unsigned long)vmalloc((trace_max_pages * PAGE_SIZE)); </snip> And some other case as well, where the cast was required... Therefore, we removed those cases by embedding a python script into the coccinelle script(yes, we can embedd python & Ocaml script if required) What I'm trying to explain is that some cases are easy to handle while some are disaster to get desired property. Also, we classify accuracy of the Coccinelle by defining a property called "Confidence" at the top of the cocci scripts. Confindence: High --> very rare chances of false postives. Moderarte --> some chances of false postivies. We always try to improve the cocci script as much as possible. If there is any MISRA-C compliant build system then its obviously great. But if not, then my proposal would be add `coccicheck` to CI and write cocci scripts to warn. For now we have some ideas that we are going to inherit from the mainline kernel like: * ARRAY_SIZE: Lots of instances in Zephyr where it is hard-coded rather than simply using the ARRAY_SIZE helper macro. * GENMASK: again we could use the helper macro instead of BIT(3) | BIT(2) | BIT(1) == GENMASK(3,1) And this GENMASK defintion is defined in: drivers/dma/dma_stm32f4x.c:#define GENMASK(h, l) (((~0UL) << (l)) & (~0UL >> (BITS_PER_LONG - 1 - (h)))) So, we could probably, move the declaration to include/misc/util.h and use it throroughly on the codebase. ...and few more. Many of the rules we made for mainline is based on enforcing usage of available standard APIs and thus avoiding developers to roll-out their own wrappers. In this way we can enforce new incoming code to adhere to the Zephyr APIs and prevent any subsequent violations/redundancy. https://github.com/zephyrproject-rtos/zephyr/pull/9725 Thanks -- Himanshu Jha Undergraduate Student Department of Electronics & Communication Guru Tegh Bahadur Institute of Technology
|
|
|
|
Re: MISRA-C and Zephyr
Flavio ceolin
Agree, we have to automate it as much as possible. But we can't just wait have all tools ready to start fixing the issues. Currently there are almost 8k violations on kernel. Any tool we setup will make a lot of noise. Some rules we will be able to check with coccinelle, but ideally we need a qualified tool with Misra c support.
On Fri, Sep 14, 2018, 21:07 Kumar Gala <kumar.gala@...> wrote: Not support MISRA directly, but I assume we can implement the MISRA checks either by configuring specific rules of cppcheck or implementing our own. If there’s some MISRA checker out there, even better.
|
|
|
|
Re: MISRA-C and Zephyr
Kumar Gala
Not support MISRA directly, but I assume we can implement the MISRA checks either by configuring specific rules of cppcheck or implementing our own. If there’s some MISRA checker out there, even better.
toggle quoted messageShow quoted text
My point is we need something as part of the GitHub PR workflow that does a bunch of the checking otherwise this isn’t really going to work. Plus it would be nice to have something we can add our own style rules into to help automate code review. - k
On Sep 14, 2018, at 10:54 PM, Nashif, Anas <anas.nashif@intel.com> wrote:
|
|
|
|
Re: MISRA-C and Zephyr
Nashif, Anas
AFAIK none of the services you list below support MISRA, some do not even support C.
toggle quoted messageShow quoted text
We are looking at https://sonarcloud.io which has an integration with GH. Anas
-----Original Message-----
From: devel@lists.zephyrproject.org [mailto:devel@lists.zephyrproject.org] On Behalf Of Kumar Gala Sent: Friday, September 14, 2018 11:47 PM To: Ceolin, Flavio <flavio.ceolin@intel.com> Cc: zephyr-devel@lists.zephyrproject.org; Nashif, Anas <anas.nashif@intel.com>; Hibberd, Amber M <amber.m.hibberd@intel.com> Subject: Re: [Zephyr-devel] MISRA-C and Zephyr On Sep 14, 2018, at 1:46 PM, Flavio Ceolin <flavio.ceolin@intel.com> wrote:Have you looked at various GitHub integration tools that might help check code for MISRA guidelines so we can automate such reviews in the future. Tools like: https://lgtm.com https://www.codacy.com https://www.codefactor.io/ I think we need some automated way to check new PRs for issues before we invest a large amount of time fixing the code base, otherwise its just going to bitrot back to being non-MISRA compliant. - k
|
|
|
|
Re: MISRA-C and Zephyr
Kumar Gala
On Sep 14, 2018, at 1:46 PM, Flavio Ceolin <flavio.ceolin@intel.com> wrote:Have you looked at various GitHub integration tools that might help check code for MISRA guidelines so we can automate such reviews in the future. Tools like: https://lgtm.com https://www.codacy.com https://www.codefactor.io/ I think we need some automated way to check new PRs for issues before we invest a large amount of time fixing the code base, otherwise its just going to bitrot back to being non-MISRA compliant. - k
|
|
|
|
Re: MISRA-C and Zephyr
Abderrezak Mekkaoui <ab.mekka@...>
Hi All,
toggle quoted messageShow quoted text
Making Zephyr MISRA-C compliant would be a huge achievement and a major selling point. It would also greatly help contributors (who are not yet award of MISRA-C or equivalent standards) to highly increase the quality of their code. Regards Abderrezak
On 9/14/2018 2:46 PM, Flavio Ceolin wrote:
Hi guys,
|
|
|
|
MISRA-C and Zephyr
Flavio Ceolin
Hi guys,
Recently I start working on Zephyr to be compliant with MISRA-C. I'd like to give you a brief overview about MISRA-C and why this is valuable to Zephyr. MISRA-C is code guideline that define a subset of C that aims to make embedded software safer, more secure and especially more portable. It does it defining a set of guidelines that try to fill the gaps between C specification and different implementations, it means things with undefined behavior, unspecified behavior and things that the compiler implementation is free to choose the behavior. That's been said, every MISRA-C guideline is classified as rule or directive. These rules and directives are classified in mandatory, required or advisory. Mandatory means that the code must be compliant with the guideline, required the code also must be compliant but it's possible creating a deviation, advisory are recommendations and don't need a formal deviation if ignored. So, what about Zephyr ? Zephyr currently contains ~8k violations and approximately half are either required or mandatory (~10). I'm filling issues on github (https://github.com/zephyrproject-rtos/zephyr/labels/MISRA-C) that contains (I hope) enough information about the problem and some suggestions to approach them. I ask everybody to take a look on them and give opinions. Some of them required collaboration of diverse code-owners and developers. To finish, why MISRA-C is valuable to Zephyr ? - Following a standard helps with maintainability of the code. - Process standards like ISO26262 and IEC61508 used to develop critical products require that the code follows a code guideline (ISO26262 explicitly recommends MISRA-C). - Other proprietary RTOs are MISRA-C compliant, if we want to be more with them, is good too. - It'll help us spot problems bugs and avoid them. I've worked this week in two guidelines that are not that intrusive and I found at least three real bugs. - We'll have less problems with different compilers, the mandatory violations are regarding using specific gcc builtin functions. If you have any questions regarding MISRA-C lets discuss it :) Regards, Flavio Ceolin
|
|
|
|
Re: [Zephyr-users] nrf52810 basic blinky example not running
Carles Cufi
Hi Marcio,
Yes, there are several people developing on nRF52810 successfully with Zephyr on custom boards. I wonder if you could dig a little bit more into it and try to debug it so we have a better idea of what’s going on?
Carles
From: users@... <users@...>
On Behalf Of Marcio Montenegro
Sent: 14 September 2018 14:52 To: zephyr-devel@...; zephyr-users@... Subject: [Zephyr-users] nrf52810 basic blinky example not running
Hi all, Is anybody developing for nrf52810 ? There is no Nordic kit for nrf52810 so I am using a custom board. The BLE module is CDEBYTE E73-2G4M04S1A:
Basic I/O of my hardware was tested on a Keil compiler project and I will test BLE radio later. zephyr.hex file was flashed using JLinkExe.
All suggestions are welcome,
|
|
|
|
[Sensor] [API] Reading multiple values from sensors
paul.adam@...
Hello,
As I found in documentation and source code, there is an interface to read one (!) value from sensors (sensor_sample_fetch_chan + sensor_channel_get). So my question is Does zephyr support reading of multiple values at one time? The use case would be:
Paul
|
|
|
|
nrf52810 basic blinky example not running
Marcio Montenegro
Hi all, Is anybody developing for nrf52810 ? There is no Nordic kit for nrf52810 so I am using a custom board. The BLE module is CDEBYTE E73-2G4M04S1A: Basic I/O of my hardware was tested on a Keil compiler project and I will test BLE radio later. zephyr.hex file was flashed using JLinkExe. All suggestions are welcome,
|
|
|
|
Re: MPU fault while testing Bluetooth Mesh Sample demos
vikrant8051 <vikrant8051@...>
Hi Carles, ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- >> Did you run addr2line in 0x20001c5c? ***** MPU FAULT ***** 1) /opt/zephyr-sdk/sysroots/x86_64-pokysdk-linux/usr/bin/arm-zephyr-eabi/arm-zephyr-eabi-addr2line -e /home/vikrant/zephyr/samples/boards/nrf52/mesh/onoff_level_lighting_vnd_app/build/zephyr/zephyr.elf 0x20001c88 & /opt/zephyr-sdk/sysroots/x86_64-pokysdk-linux/usr/bin/arm-zephyr-eabi/arm-zephyr-eabi-addr2line -e /home/vikrant/zephyr/samples/boards/nrf52/mesh/onoff_level_lighting_vnd_app/build/zephyr/zephyr.elf 0x20001884 Both returns -> :? ...... with zephyr-SDK 2) I also tried to compile the App using latest gcc-arm-none-eabi-7-2018-q2 2.1) /opt/gcc-arm-none-eabi-7-2018-q2-update/bin/arm-none-eabi-addr2line -e /home/vikrant/zephyr/samples/boards/nrf52/mesh/onoff_level_lighting_vnd_app/build/zephyr/zephyr.elf 0x20001c88 o/p -> isr_tables.c:? 2.2) /opt/gcc-arm-none-eabi-7-2018-q2-update/bin/arm-none-eabi-addr2line -e /home/vikrant/zephyr/samples/boards/nrf52/mesh/onoff_level_lighting_vnd_app/build/zephyr/zephyr.elf 0x20001884 o/p -> /home/vikrant/zephyr/kernel/init.c:80 ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- >> Have you tried increasing stack sizes? Yes. CONFIG_MAIN_STACK_SIZE=512 ....to 1024 But still getting MPU Fault in case of Board executing BT Mesh Servers.
On Fri, Sep 14, 2018 at 3:31 PM Cufi, Carles <Carles.Cufi@...> wrote:
|
|
|
