I2C is not working for STM-based board


Dmitry Shmidt
 

Hello,

Change for cmake build:

commit 12f8f7616567f224b920512b6f81a65421e30bae
Author: Sebastian Bøe <sebastian.boe@nordicsemi.no>
Date: Fri Oct 27 15:43:34 2017 +0200
Introduce cmake-based rewrite of KBuild

set CONFIG_I2C_STM32_V1x instead of CONFIG_I2C_STM32_V1

Was it intentional or should we use old value like this:

diff --git a/drivers/i2c/CMakeLists.txt b/drivers/i2c/CMakeLists.txt
index 3a544930f..8f8fb67d1 100644
--- a/drivers/i2c/CMakeLists.txt
+++ b/drivers/i2c/CMakeLists.txt
@@ -10,7 +10,7 @@ zephyr_sources_ifdef(CONFIG_I2C_QMSI_SS
i2c_qmsi_ss.c)
zephyr_sources_ifdef(CONFIG_I2C_SAM_TWI i2c_sam_twi.c)
zephyr_sources_ifdef(CONFIG_I2C_SBCON i2c_sbcon.c)

-zephyr_sources_ifdef(CONFIG_I2C_STM32_V1x
+zephyr_sources_ifdef(CONFIG_I2C_STM32_V1
i2c_ll_stm32_v1.c
i2c_ll_stm32.c
)

Thanks,

Dmitry


Yannis Damigos
 

Hi Dmitry,

Thanks for catching this. It is a typo.
Could you create a PR on github to fix it?

Yannis

On Tue, Nov 14, 2017 at 9:21 PM, Dmitry Shmidt via Zephyr-devel
<zephyr-devel@lists.zephyrproject.org> wrote:
Hello,

Change for cmake build:

commit 12f8f7616567f224b920512b6f81a65421e30bae
Author: Sebastian Bøe <sebastian.boe@nordicsemi.no>
Date: Fri Oct 27 15:43:34 2017 +0200
Introduce cmake-based rewrite of KBuild

set CONFIG_I2C_STM32_V1x instead of CONFIG_I2C_STM32_V1

Was it intentional or should we use old value like this:

diff --git a/drivers/i2c/CMakeLists.txt b/drivers/i2c/CMakeLists.txt
index 3a544930f..8f8fb67d1 100644
--- a/drivers/i2c/CMakeLists.txt
+++ b/drivers/i2c/CMakeLists.txt
@@ -10,7 +10,7 @@ zephyr_sources_ifdef(CONFIG_I2C_QMSI_SS
i2c_qmsi_ss.c)
zephyr_sources_ifdef(CONFIG_I2C_SAM_TWI i2c_sam_twi.c)
zephyr_sources_ifdef(CONFIG_I2C_SBCON i2c_sbcon.c)

-zephyr_sources_ifdef(CONFIG_I2C_STM32_V1x
+zephyr_sources_ifdef(CONFIG_I2C_STM32_V1
i2c_ll_stm32_v1.c
i2c_ll_stm32.c
)

Thanks,

Dmitry
_______________________________________________
Zephyr-devel mailing list
Zephyr-devel@lists.zephyrproject.org
https://lists.zephyrproject.org/mailman/listinfo/zephyr-devel


Sebastian Boe
 

PR: https://github.com/zephyrproject-rtos/zephyr/pull/4984

github.com
Fix typo in build scripts for STM's I2C driver. The typo was introduced in the cmake migration. Discovered by Dmitry: https://lists.zephyrproject.org/pipermail/zephyr-devel/2017-November/008383.htm...


From: zephyr-devel-bounces@... <zephyr-devel-bounces@...> on behalf of Yannis Damigos <giannis.damigos@...>
Sent: Wednesday, 15 November 2017 7:58:23 AM
To: Dmitry Shmidt
Cc: zephyr-devel
Subject: Re: [Zephyr-devel] I2C is not working for STM-based board
 
Hi Dmitry,

Thanks for catching this. It is a typo.
Could you create a PR on github to fix it?

Yannis

On Tue, Nov 14, 2017 at 9:21 PM, Dmitry Shmidt via Zephyr-devel
<zephyr-devel@...> wrote:
> Hello,
>
> Change for cmake build:
>
> commit 12f8f7616567f224b920512b6f81a65421e30bae
> Author: Sebastian Bøe <sebastian.boe@...>
> Date:   Fri Oct 27 15:43:34 2017 +0200
>     Introduce cmake-based rewrite of KBuild
>
> set CONFIG_I2C_STM32_V1x instead of CONFIG_I2C_STM32_V1
>
> Was it intentional or should we use old value like this:
>
> diff --git a/drivers/i2c/CMakeLists.txt b/drivers/i2c/CMakeLists.txt
> index 3a544930f..8f8fb67d1 100644
> --- a/drivers/i2c/CMakeLists.txt
> +++ b/drivers/i2c/CMakeLists.txt
> @@ -10,7 +10,7 @@ zephyr_sources_ifdef(CONFIG_I2C_QMSI_SS
>  i2c_qmsi_ss.c)
>  zephyr_sources_ifdef(CONFIG_I2C_SAM_TWI     i2c_sam_twi.c)
>  zephyr_sources_ifdef(CONFIG_I2C_SBCON          i2c_sbcon.c)
>
> -zephyr_sources_ifdef(CONFIG_I2C_STM32_V1x
> +zephyr_sources_ifdef(CONFIG_I2C_STM32_V1
>         i2c_ll_stm32_v1.c
>         i2c_ll_stm32.c
>         )
>
> Thanks,
>
> Dmitry
> _______________________________________________
> Zephyr-devel mailing list
> Zephyr-devel@...
> https://lists.zephyrproject.org/mailman/listinfo/zephyr-devel
_______________________________________________
Zephyr-devel mailing list
Zephyr-devel@...
https://lists.zephyrproject.org/mailman/listinfo/zephyr-devel