Date
1 - 4 of 4
Things to do when submitting a PR
Nashif, Anas
Hi, Here is a TOP10 list to improve and accelerate the review process of pull requests. If you follow them, chances are your pull request will get the attention needed and it will be ready for merge sooner than later:
Regards,
Anas |
|
Glaropoulos, Ioannis
Thanks! Could this be (if not already) part of a “best-practices” section in our Contribution guidelines?
/Ioannis
From: devel@... <devel@...>
On Behalf Of Nashif, Anas via lists.zephyrproject.org
Sent: Tuesday, June 1, 2021 2:49 PM To: devel@... Subject: [Zephyr-devel] Things to do when submitting a PR
Hi, Here is a TOP10 list to improve and accelerate the review process of pull requests. If you follow them, chances are your pull request will get the attention needed and it will be ready for merge sooner than later:
Regards,
Anas |
|
Nicolas Pitre
On Tue, 1 Jun 2021, Nashif, Anas wrote:
2. Run compliance tests locally and fix any issues before submitting a PRCould such somewhat criptic commands be grouped into an easy to run and remember ./scripts/pre-submit-validation script? Something that needs no arguments and does the right thing out of the box. Nicolas |
|
Yasushi SHOJI
Hi,
On Tue, Jun 1, 2021 at 9:48 PM Nashif, Anas <anas.nashif@...> wrote: Add reviewers if you can and know who will be able to review your codeCan a regular contributor do this? Using a mention? I'd love to fix scripts/get_maintainer.py in order to find who to ask. Set the labels if those are not automatically set by the bot.If you don't have write permission, you can't add any label, right? -- yashi |
|