---

From: devel@... <devel@...> On Behalf Of Nashif, Anas via lists.zephyrproject.org
Sent: Friday, February 11, 2022 8:42 AM
To: devel@...
Subject: [Zephyr-devel] Changes to Review Process in Github

 

Hit send too fast… fixed subject.

 

Hi,

The TSC has discussed and voted in favor of changing the pull request and review process by enabling options provided by Github.

 

Specifically, we will be enabling an option that will cause new reviewable commits pushed to a pull-request branch to dismiss existing pull request review approvals and asking reviewers to revisit and re-review the new changes since they last reviewed the PR.

 

For reference, here is the settings screen with the option enabled:

 

 

This means that you will be asked to re-review changes when new content is being added to a pull-request. Please continue to provide reviews and keep watching for changes and enhancements added to pull-requests as they evolve.

 

This change will go into effect immediately.

 

Regards,

Anas

From: devel@... <devel@...> On Behalf Of David Leach via lists.zephyrproject.org
Sent: Friday, February 11, 2022 2:59 PM
To: anas.nashif@...; devel@...
Subject: Re: [Zephyr-devel] Changes to Review Process in Github

 

Just FYI, for reasons unknown, GitHub is attributing the dismissed approved reviews to my account, dleach02. I am not doing this and I have submitted a bug to the GitHub support to get them to look into this.

 

David Leach

 

 

Hit send too fast… fixed subject.

 

Hi,

The TSC has discussed and voted in favor of changing the pull request and review process by enabling options provided by Github.

 

Specifically, we will be enabling an option that will cause new reviewable commits pushed to a pull-request branch to dismiss existing pull request review approvals and asking reviewers to revisit and re-review the new changes since they last reviewed the PR.

 

For reference, here is the settings screen with the option enabled:

 

 

This means that you will be asked to re-review changes when new content is being added to a pull-request. Please continue to provide reviews and keep watching for changes and enhancements added to pull-requests as they evolve.

 

This change will go into effect immediately.

 

Regards,

Anas

On Fri, Feb 11 2022, Emil via lists zephyrproject org Gydesen wrote:

Hi Anas,

A question on the feature:

If I rebase a PR without changing the content, does it trigger request for new reviews?

Also a clarification:
The text says "New reviewable commits pushed" - Does that also trigger if you amend an existing commit and push that, or is it only if you add new commits?

Best regards,
Emil Gydesen
Software Developer, Nordic Semiconductor | +4528265669 | emil.gydesen@...
________________________________
From: devel@... <devel@...> on behalf of Nashif, Anas via lists.zephyrproject.org <anas.nashif=intel.com@...>
Sent: Friday, February 11, 2022 15:41
To: devel@... <devel@...>
Subject: [Zephyr-devel] Changes to Review Process in Github


Hit send too fast… fixed subject.



From: Nashif, Anas <anas.nashif@...>
Date: Friday, February 11, 2022 at 9:40 AM
To: devel@... <devel@...>
Subject: Changes to

Hi,

The TSC has discussed and voted in favor of changing the pull request and review process by enabling options provided by Github.



Specifically, we will be enabling an option that will cause new reviewable commits pushed to a pull-request branch to dismiss existing pull request review approvals and asking reviewers to revisit and re-review the new changes since they last reviewed the PR.



For reference, here is the settings screen with the option enabled:



[Graphical user interface, text, application, email Description automatically generated]



This means that you will be asked to re-review changes when new content is being added to a pull-request. Please continue to provide reviews and keep watching for changes and enhancements added to pull-requests as they evolve.



This change will go into effect immediately.



Regards,

Anas

From: devel@... <devel@...> On Behalf Of David Leach via lists.zephyrproject.org
Sent: Wednesday, February 23, 2022 7:24 AM
To: anas.nashif@...; devel@...
Subject: Re: [Zephyr-devel] Changes to Review Process in Github

 

Update from GitHub support:

 

GitHub Support (GitHub Support)

Feb 23, 2022, 10:10 AM UTC

Hi David,

Thanks for reaching out to GitHub Support! Sorry for not getting back to you as quickly as we'd like! Please accept my apologies.

We have received a few similar reports of this issue, and the team has been investigating. I've added your report as another data point to our internal issue. While we don’t yet have a specific ETA, we’ll be sure to update you as soon as there’s any news to share.

Feel free to come back to me if there's anything else you need.

Regards,
Peter
GitHub Support

 

 

 

 

Just FYI, for reasons unknown, GitHub is attributing the dismissed approved reviews to my account, dleach02. I am not doing this and I have submitted a bug to the GitHub support to get them to look into this.

 

David Leach

 

 

Hit send too fast… fixed subject.

 

Hi,

The TSC has discussed and voted in favor of changing the pull request and review process by enabling options provided by Github.

 

Specifically, we will be enabling an option that will cause new reviewable commits pushed to a pull-request branch to dismiss existing pull request review approvals and asking reviewers to revisit and re-review the new changes since they last reviewed the PR.

 

For reference, here is the settings screen with the option enabled:

 

 

This means that you will be asked to re-review changes when new content is being added to a pull-request. Please continue to provide reviews and keep watching for changes and enhancements added to pull-requests as they evolve.

 

This change will go into effect immediately.

 

Regards,

Anas