1. Devel
  2. Topics

CAN support on STM32G431RB #stm32

Mariana Ücker
 

Hello everyone,
 
I started working with zephyr two months ago, but I never opened a pull request.
I'm developing an application with CAN interface for the STM32G431KB and for that, I needed to add support for the NUCLEO_g431kb. Also, I noticed that the STM32G431RB has CAN communication interface. However, the support for NUCLEO_g431rb board does not include the necessary settings for using the CAN interface.
So my question is: Can I open a pull request to add CAN on the Nucleo_g431rb board? I added the changes, but as I don't have the nucleo_g431rb board, I couldn't test. I only tested the files that I added to the nucleo_g431kb board.

Thanks for your time!
Henrik Brix Andersen
 

Hi,

On 2 Sep 2022, at 22.34, Mariana Ücker <mariana@...> wrote:
I started working with zephyr two months ago, but I never opened a pull request.
I'm developing an application with CAN interface for the STM32G431KB and for that, I needed to add support for the NUCLEO_g431kb. Also, I noticed that the STM32G431RB has CAN communication interface. However, the support for NUCLEO_g431rb board does not include the necessary settings for using the CAN interface.
So my question is: Can I open a pull request to add CAN on the Nucleo_g431rb board? I added the changes, but as I don't have the nucleo_g431rb board, I couldn't test. I only tested the files that I added to the nucleo_g431kb board.
No. Please do not submit PRs for untested features. It will only cause headaches for the next person trying to use it.

./Brix
--
Henrik Brix Andersen

1 - 2 of 2