gsm_modem sample changed in Zephyr 2.7 #ppp


Brenton Chetty
 

Hi there,

I was using the Zephyr 2.6 branch, and I got the gsm_sample to work for my application. I was using the nrf5340dk_nrf5340_cpuapp with a U-blox R211 gsm modem.

However, when I updated to Zephyr 2.7.99, I can no longer compile the gsm_modem sample.
I receive the following error : "fatal error: drivers/gsm_ppp.h: No such file or directory".

My overlay file contains the following:
&uart1 {
    status = "okay";
    current-speed = <115200>;
    tx-pin = <33>;
    rx-pin = <32>;
    rts-pin = <11>;
    cts-pin = <10>;
    gsm: gsm-modem {
        compatible = "zephyr,gsm-ppp";
        label = "gsm_ppp";
    };
};

May you please advise me on whatever configuration I seem to be missing?

With Festive Greetings :)
Brenton Chetty


William Fish
 

You may just need to just do a "pristine" build or delete the build folder as the file was moved a while ago to conform with coding standards.

Billy..


Brenton Chetty
 

Hi. I did try removing my build folder and using the pristine build, both did not help unfortunately. I am also using a clean install of Ubuntu and Zephyr, so the sample should have worked out of the box. I am totally baffled by this issue.

Regards
Brenton


On Wed, Dec 8, 2021 at 11:45 AM William Fish <William.fish@...> wrote:
You may just need to just do a "pristine" build or delete the build folder as the file was moved a while ago to conform with coding standards.

Billy..


Jukka Rissanen
 

Hi Brenton,



Cheers,
Jukka


On Wed, 2021-12-08 at 15:04 +0200, Brenton Chetty wrote:
Hi. I did try removing my build folder and using the pristine build, both did not help unfortunately. I am also using a clean install of Ubuntu and Zephyr, so the sample should have worked out of the box. I am totally baffled by this issue.

Regards
Brenton

On Wed, Dec 8, 2021 at 11:45 AM William Fish <William.fish@...> wrote:
You may just need to just do a "pristine" build or delete the build folder as the file was moved a while ago to conform with coding standards.

Billy..



William Fish
 

Looked at the file structure to check: "fatal error: drivers/gsm_ppp.h: No such file or directory". Not so surprisingly the header file is not in the drivers folder it is in the drivers/modem folder, appears something has gone wrong with our testing.

The offending code is in \samples\net\gsm_modem\src\main.c: line 14 
#include <drivers/gsm_ppp.h>

It should be removed and that should fix it, give it a try and please raise an issue in the Zephyr Git.

In the future could show more of the error; i.e. which file & line the include statement is? This really helps find the issue.

Thanks,

Billy..


Brenton Chetty
 

Thank you guys for your help.

I can't believe, I didn't think of removing that line. I think I need to take my work leave earlier lol.
And yes, Next time I will include more information about potential errors.

With much appreciation
Brenton


On Wed, Dec 8, 2021 at 4:54 PM William Fish <William.fish@...> wrote:
Looked at the file structure to check: "fatal error: drivers/gsm_ppp.h: No such file or directory". Not so surprisingly the header file is not in the drivers folder it is in the drivers/modem folder, appears something has gone wrong with our testing.

The offending code is in \samples\net\gsm_modem\src\main.c: line 14 
#include <drivers/gsm_ppp.h>

It should be removed and that should fix it, give it a try and please raise an issue in the Zephyr Git.

In the future could show more of the error; i.e. which file & line the include statement is? This really helps find the issue.

Thanks,

Billy..